pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
pgsql: Prevent CRLF conversion of inputs in json_parser test module
2+ messages / 1 participants
[nested] [flat]

* pgsql: Prevent CRLF conversion of inputs in json_parser test module
@ 2024-07-09 21:34  Andrew Dunstan <andrew@dunslane.net>
  0 siblings, 0 replies; 2+ messages in thread

From: Andrew Dunstan @ 2024-07-09 21:34 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Prevent CRLF conversion of inputs in json_parser test module

Do this by opening the file in PG_BINARY_R mode. This prevents us from
getting wrong byte count from stat().

Per complaint from Andres Freund

Discussion: https://postgr.es/m/20240707052030.r77hbdkid3mwksop@awork3.anarazel.de

Backpatch to rlease 17 where this code was introduced

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/f7bd0a381de12a5c309f3c19d8c966b77e87cff3

Modified Files
--------------
src/test/modules/test_json_parser/test_json_parser_incremental.c | 2 +-
src/test/modules/test_json_parser/test_json_parser_perf.c        | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)



^ permalink  raw  reply  [nested|flat] 2+ messages in thread

* pgsql: Prevent CRLF conversion of inputs in json_parser test module
@ 2024-07-09 21:34  Andrew Dunstan <andrew@dunslane.net>
  0 siblings, 0 replies; 2+ messages in thread

From: Andrew Dunstan @ 2024-07-09 21:34 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Prevent CRLF conversion of inputs in json_parser test module

Do this by opening the file in PG_BINARY_R mode. This prevents us from
getting wrong byte count from stat().

Per complaint from Andres Freund

Discussion: https://postgr.es/m/20240707052030.r77hbdkid3mwksop@awork3.anarazel.de

Backpatch to rlease 17 where this code was introduced

Branch
------
REL_17_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/e72f787ea6b287ed624c1f5be71eb13e405b1577

Modified Files
--------------
src/test/modules/test_json_parser/test_json_parser_incremental.c | 2 +-
src/test/modules/test_json_parser/test_json_parser_perf.c        | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)



^ permalink  raw  reply  [nested|flat] 2+ messages in thread


end of thread, other threads:[~2024-07-09 21:34 UTC | newest]

Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2024-07-09 21:34 pgsql: Prevent CRLF conversion of inputs in json_parser test module Andrew Dunstan <andrew@dunslane.net>
2024-07-09 21:34 pgsql: Prevent CRLF conversion of inputs in json_parser test module Andrew Dunstan <andrew@dunslane.net>

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox