From: Andrew Dunstan <andrew@dunslane.net>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Prevent CRLF conversion of inputs in json_parser test module
Date: Tue, 09 Jul 2024 21:34:57 +0000
Message-ID: <E1sRIUD-0012Us-6G@gemulon.postgresql.org> (raw)
Prevent CRLF conversion of inputs in json_parser test module
Do this by opening the file in PG_BINARY_R mode. This prevents us from
getting wrong byte count from stat().
Per complaint from Andres Freund
Discussion: https://postgr.es/m/20240707052030.r77hbdkid3mwksop@awork3.anarazel.de
Backpatch to rlease 17 where this code was introduced
Branch
------
REL_17_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/e72f787ea6b287ed624c1f5be71eb13e405b1577
Modified Files
--------------
src/test/modules/test_json_parser/test_json_parser_incremental.c | 2 +-
src/test/modules/test_json_parser/test_json_parser_perf.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: andrew@dunslane.net, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Prevent CRLF conversion of inputs in json_parser test module
In-Reply-To: <E1sRIUD-0012Us-6G@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox