pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Improve logical replication connection-failure messages.
Date: Thu, 11 Jul 2024 17:21:20 +0000
Message-ID: <E1sRxTs-001H4x-Ka@gemulon.postgresql.org> (raw)

Improve logical replication connection-failure messages.

These messages mostly said "could not connect to the publisher: %s"
which is lacking context.  Add some verbiage to indicate which
subscription or worker process is failing.

Nisha Moond

Discussion: https://postgr.es/m/CABdArM7q1=zqL++cYd0hVMg3u_tc0S=0Of=Um-KvDhLony0cSg@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/0d8bd0a72ea284ffb1d1154efbe799241cc5edc6

Modified Files
--------------
src/backend/commands/subscriptioncmds.c     | 9 ++++++---
src/backend/replication/logical/slotsync.c  | 3 ++-
src/backend/replication/logical/tablesync.c | 3 ++-
src/backend/replication/logical/worker.c    | 3 ++-
src/backend/replication/slotfuncs.c         | 3 ++-
src/backend/replication/walreceiver.c       | 9 +++++----
src/test/regress/expected/subscription.out  | 2 +-
7 files changed, 20 insertions(+), 12 deletions(-)



Message-ID: <E1sRxTs-001H4x-Ka@gemulon.postgresql.org>
Permalink:  ../E1sRxTs-001H4x-Ka@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1sRxTs-001H4x-Ka@gemulon.postgresql.org

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Improve logical replication connection-failure messages.
  In-Reply-To: <E1sRxTs-001H4x-Ka@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox