pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Andrew Dunstan <andrew@dunslane.net>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Make sure to run pg_isready on correct port
Date: Sat, 13 Jul 2024 12:15:11 +0000
Message-ID: <E1sSbeh-001V3T-2t@gemulon.postgresql.org> (raw)

Make sure to run pg_isready on correct port

The current code can have pg_isready unexpectedly succeed if there is a
server running on the default port. To avoid this we delay running the
test until after a node has been created but before it starts, and then
use that node's port, so we are fairly sure there is nothing running on
the port.

Backpatch to all live branches.

Branch
------
REL_16_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/75f4ae2b8065ca7d29bec55f261828f794fbba1e

Modified Files
--------------
src/bin/scripts/t/080_pg_isready.pl | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)



view thread (7+ messages)  latest in thread

Message-ID: <E1sSbeh-001V3T-2t@gemulon.postgresql.org>
Permalink:  ../E1sSbeh-001V3T-2t@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1sSbeh-001V3T-2t@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: andrew@dunslane.net, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Make sure to run pg_isready on correct port
  In-Reply-To: <E1sSbeh-001V3T-2t@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox