From: Thomas Munro <tmunro@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Run LLVM verify pass on IR in assert builds.
Date: Mon, 15 Jul 2024 09:50:51 +0000
Message-ID: <E1sTIM7-001ju6-OY@gemulon.postgresql.org> (raw)
Run LLVM verify pass on IR in assert builds.
The problem fixed by commit 53c8d6c9 would have been noticed if we'd
been running LLVM's verify pass on generated IR. Doing so also reveals
a complaint about incorrect name mangling, fixed here. Only enabled for
LLVM 17+ because it uses the new pass manager API.
Suggested-by: Dmitry Dolgov <9erthalion6@gmail.com>
Discussion: https://postgr.es/m/CAFj8pRACpVFr7LMdVYENUkScG5FCYMZDDdSGNU-tch%2Bw98OxYg%40mail.gmail.com
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/8583b1f99340f4de24661dc50ab63ec6965f6759
Modified Files
--------------
src/backend/jit/llvm/llvmjit.c | 5 +++++
src/backend/jit/llvm/llvmjit_expr.c | 2 +-
2 files changed, 6 insertions(+), 1 deletion(-)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: tmunro@postgresql.org, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Run LLVM verify pass on IR in assert builds.
In-Reply-To: <E1sTIM7-001ju6-OY@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox