pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
pgsql: Add missing call to ConditionVariableCancelSleep().
2+ messages / 1 participants
[nested] [flat]

* pgsql: Add missing call to ConditionVariableCancelSleep().
@ 2024-07-22 14:19  Robert Haas <rhaas@postgresql.org>
  0 siblings, 0 replies; 2+ messages in thread

From: Robert Haas @ 2024-07-22 14:19 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Add missing call to ConditionVariableCancelSleep().

After calling ConditionVariableSleep() or ConditionVariableTimedSleep()
one or more times, code is supposed to call ConditionVariableCancelSleep()
to remove itself from the waitlist. This code neglected to do so.
As far as I know, that had no observable consequences, but let's make
the code correct.

Discussion: http://postgr.es/m/CA+TgmoYW8eR+KN6zhVH0sin7QH6AvENqw_bkN-bB4yLYKAnsew@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/c0348fd0e389c89003f309918705d1daea2217b0

Modified Files
--------------
src/backend/postmaster/walsummarizer.c | 2 ++
1 file changed, 2 insertions(+)



^ permalink  raw  reply  [nested|flat] 2+ messages in thread

* pgsql: Add missing call to ConditionVariableCancelSleep().
@ 2024-07-22 14:19  Robert Haas <rhaas@postgresql.org>
  0 siblings, 0 replies; 2+ messages in thread

From: Robert Haas @ 2024-07-22 14:19 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Add missing call to ConditionVariableCancelSleep().

After calling ConditionVariableSleep() or ConditionVariableTimedSleep()
one or more times, code is supposed to call ConditionVariableCancelSleep()
to remove itself from the waitlist. This code neglected to do so.
As far as I know, that had no observable consequences, but let's make
the code correct.

Discussion: http://postgr.es/m/CA+TgmoYW8eR+KN6zhVH0sin7QH6AvENqw_bkN-bB4yLYKAnsew@mail.gmail.com

Branch
------
REL_17_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/6c8d2ea7a5fb7f85e5f64994affa33e79c19ddd3

Modified Files
--------------
src/backend/postmaster/walsummarizer.c | 2 ++
1 file changed, 2 insertions(+)



^ permalink  raw  reply  [nested|flat] 2+ messages in thread


end of thread, other threads:[~2024-07-22 14:19 UTC | newest]

Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2024-07-22 14:19 pgsql: Add missing call to ConditionVariableCancelSleep(). Robert Haas <rhaas@postgresql.org>
2024-07-22 14:19 pgsql: Add missing call to ConditionVariableCancelSleep(). Robert Haas <rhaas@postgresql.org>

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox