pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Robert Haas <rhaas@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Add missing call to ConditionVariableCancelSleep().
Date: Mon, 22 Jul 2024 14:19:27 +0000
Message-ID: <E1sVtst-000ice-0f@gemulon.postgresql.org> (raw)

Add missing call to ConditionVariableCancelSleep().

After calling ConditionVariableSleep() or ConditionVariableTimedSleep()
one or more times, code is supposed to call ConditionVariableCancelSleep()
to remove itself from the waitlist. This code neglected to do so.
As far as I know, that had no observable consequences, but let's make
the code correct.

Discussion: http://postgr.es/m/CA+TgmoYW8eR+KN6zhVH0sin7QH6AvENqw_bkN-bB4yLYKAnsew@mail.gmail.com

Branch
------
REL_17_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/6c8d2ea7a5fb7f85e5f64994affa33e79c19ddd3

Modified Files
--------------
src/backend/postmaster/walsummarizer.c | 2 ++
1 file changed, 2 insertions(+)



view thread (2+ messages)

Message-ID: <E1sVtst-000ice-0f@gemulon.postgresql.org>
Permalink:  ../E1sVtst-000ice-0f@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1sVtst-000ice-0f@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: rhaas@postgresql.org, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Add missing call to ConditionVariableCancelSleep().
  In-Reply-To: <E1sVtst-000ice-0f@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox