pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Melanie Plageman <melanieplageman@gmail.com>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Revert "Test that vacuum removes tuples older than OldestXmin"
Date: Mon, 22 Jul 2024 21:01:53 +0000
Message-ID: <E1sW0AL-000lJ3-Hx@gemulon.postgresql.org> (raw)

Revert "Test that vacuum removes tuples older than OldestXmin"

This reverts commit 80c34692e8e674e3b2f150f248ef2002ae2ac3a7.

This test proved to be unstable on the buildfarm, timing out before the
standby could catch up on 32-bit machines where more rows were required
and failing to reliably trigger multiple index vacuum rounds on 64-bit
machines where fewer rows should be required.

Because the instability is only known to be present on versions of
Postgres with TIDStore used for dead TID storage by vacuum, this is only
being reverted on master and REL_17_STABLE.

As having this coverage may be valuable, there is a discussion on the
thread of possible ways to stabilize the test. If that happens, a fixed
test can be committed again.

Backpatch-through: 17
Reported-by: Tom Lane

Discussion: https://postgr.es/m/614152.1721580711%40sss.pgh.pa.us

Branch
------
REL_17_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/1a3e90948b50abef3a075c5b1d1c59a9d631a187

Modified Files
--------------
src/test/recovery/meson.build                   |   1 -
src/test/recovery/t/043_vacuum_horizon_floor.pl | 268 ------------------------
2 files changed, 269 deletions(-)



view thread (2+ messages)

Message-ID: <E1sW0AL-000lJ3-Hx@gemulon.postgresql.org>
Permalink:  ../E1sW0AL-000lJ3-Hx@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1sW0AL-000lJ3-Hx@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: melanieplageman@gmail.com, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Revert "Test that vacuum removes tuples older than OldestXmin"
  In-Reply-To: <E1sW0AL-000lJ3-Hx@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox