From: Peter Eisentraut <peter@eisentraut.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Move extern declarations for EXEC_BACKEND to header files
Date: Tue, 23 Jul 2024 13:15:02 +0000
Message-ID: <E1sWFM6-000r2T-S0@gemulon.postgresql.org> (raw)
Move extern declarations for EXEC_BACKEND to header files
This fixes warnings from -Wmissing-variable-declarations (not yet part
of the standard warning options) under EXEC_BACKEND. The
NON_EXEC_STATIC variables need a suitable declaration in a header file
under EXEC_BACKEND.
Also fix the inconsistent application of the volatile qualifier for
PMSignalState, which was revealed by this change.
Reviewed-by: Andres Freund <andres@anarazel.de>
Discussion: https://www.postgresql.org/message-id/flat/e0a62134-83da-4ba4-8cdb-ceb0111c95ce@eisentraut.org
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/d3cc5ffe81f64c6418ba9b18a9db32392f8027e6
Modified Files
--------------
src/backend/postmaster/launch_backend.c | 12 +-----------
src/include/postmaster/postmaster.h | 4 ++++
src/include/postmaster/syslogger.h | 4 ++++
src/include/storage/pmsignal.h | 4 ++++
src/include/storage/proc.h | 5 +++++
5 files changed, 18 insertions(+), 11 deletions(-)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: peter@eisentraut.org, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Move extern declarations for EXEC_BACKEND to header files
In-Reply-To: <E1sWFM6-000r2T-S0@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox