From: Thomas Munro <tmunro@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Refactor tidstore.c iterator buffering.
Date: Wed, 24 Jul 2024 05:33:39 +0000
Message-ID: <E1sWUd9-000wsz-NC@gemulon.postgresql.org> (raw)
Refactor tidstore.c iterator buffering.
Previously, TidStoreIterateNext() would expand the set of offsets for
each block into an internal buffer that it overwrote each time. In
order to be able to collect the offsets for multiple blocks before
working with them, change the contract. Now, the offsets are obtained
by a separate call to TidStoreGetBlockOffsets(), which can be called at
a later time. TidStoreIteratorResult objects are safe to copy and store
in a queue.
Reviewed-by: Noah Misch <noah@leadboat.com>
Discussion: https://postgr.es/m/CAAKRu_bbkmwAzSBgnezancgJeXrQZXy4G4kBTd+5=cr86H5yew@mail.gmail.com
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/f6bef362cac8c47137f9786171eaee5a95fb538b
Modified Files
--------------
src/backend/access/common/tidstore.c | 63 ++++++++++++--------------
src/backend/access/heap/vacuumlazy.c | 9 +++-
src/include/access/tidstore.h | 12 +++--
src/test/modules/test_tidstore/test_tidstore.c | 9 +++-
4 files changed, 51 insertions(+), 42 deletions(-)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: tmunro@postgresql.org, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Refactor tidstore.c iterator buffering.
In-Reply-To: <E1sWUd9-000wsz-NC@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox