From: Peter Eisentraut <peter@eisentraut.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Add extern declarations for Bison global variables
Date: Thu, 25 Jul 2024 07:32:13 +0000
Message-ID: <E1sWsxR-0017Qh-2t@gemulon.postgresql.org> (raw)
Add extern declarations for Bison global variables
This adds extern declarations for some global variables produced by
Bison that are not already declared in its generated header file.
This is a workaround to be able to add -Wmissing-variable-declarations
to the global set of warning options in the near future.
Another longer-term solution would be to convert these grammars to
"pure" parsers in Bison, to avoid global variables altogether. Note
that the core grammar is already pure, so this patch did not need to
touch it.
Reviewed-by: Andres Freund <andres@anarazel.de>
Discussion: https://www.postgresql.org/message-id/flat/e0a62134-83da-4ba4-8cdb-ceb0111c95ce@eisentraut.org
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/ab61c40bfa2ba1887fee304b2ef5306a14a7248c
Modified Files
--------------
contrib/cube/cubeparse.y | 4 ++++
contrib/seg/segparse.y | 4 ++++
src/backend/bootstrap/bootparse.y | 5 +++++
src/backend/replication/repl_gram.y | 5 +++++
src/backend/replication/syncrep_gram.y | 4 ++++
src/interfaces/ecpg/preproc/ecpg.header | 4 ++++
src/pl/plpgsql/src/pl_gram.y | 4 ++++
src/test/isolation/specparse.y | 3 +++
8 files changed, 33 insertions(+)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: peter@eisentraut.org, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Add extern declarations for Bison global variables
In-Reply-To: <E1sWsxR-0017Qh-2t@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox