pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Amit Langote <amitlan@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: SQL/JSON: Respect OMIT QUOTES when RETURNING domains over jsonb
Date: Fri, 26 Jul 2024 07:43:43 +0000
Message-ID: <E1sXFc7-001GeB-2i@gemulon.postgresql.org> (raw)

SQL/JSON: Respect OMIT QUOTES when RETURNING domains over jsonb

populate_domain() didn't take into account the omit_quotes flag passed
down to json_populate_type() by ExecEvalJsonCoercion() and that led
to incorrect behavior when the RETURNING type is a domain over
jsonb.  Fix that by passing the flag by adding a new function
parameter to populate_domain().

Reported-by: Jian He <jian.universality@gmail.com>
Discussion: https://postgr.es/m/CACJufxEo4sUjKCYtda0_qt9tazqqKPmF1cqhW9KBOUeJFqQd2g@mail.gmail.com
Backpatch-through: 17

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/4fc6a555606de003690d46e900339e78214ee363

Modified Files
--------------
src/backend/utils/adt/jsonfuncs.c                | 11 ++++++-----
src/test/regress/expected/sqljson_queryfuncs.out | 15 +++++++++++++++
src/test/regress/sql/sqljson_queryfuncs.sql      |  5 +++++
3 files changed, 26 insertions(+), 5 deletions(-)



view thread (2+ messages)

Message-ID: <E1sXFc7-001GeB-2i@gemulon.postgresql.org>
Permalink:  ../E1sXFc7-001GeB-2i@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1sXFc7-001GeB-2i@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: amitlan@postgresql.org, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: SQL/JSON: Respect OMIT QUOTES when RETURNING domains over jsonb
  In-Reply-To: <E1sXFc7-001GeB-2i@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox