pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Richard Guo <rguo@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Simplify create_merge_append_path for clarity
Date: Mon, 29 Jul 2024 02:37:19 +0000
Message-ID: <E1sYGGF-001gjV-53@gemulon.postgresql.org> (raw)

Simplify create_merge_append_path for clarity

We don't currently support parameterized MergeAppend paths: there's
little use for an ordered path on the inside of a nestloop.  Given
this, we can simplify create_merge_append_path by directly setting
param_info to NULL instead of calling get_appendrel_parampathinfo.  We
can also simplify the Assert for child paths a little bit.

This change won't make any measurable difference in performance; it's
just for clarity's sake.

Author: Richard Guo
Reviewed-by: Alena Rybakina, Paul A Jungwirth
Discussion: https://postgr.es/m/CAMbWs4_n1bgH2nACMuGsXZct3KH6PBFS0tPdQsXdstRfyxTunQ@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/f47b33a19115f432ad80777db0d1350d23bb6cf5

Modified Files
--------------
src/backend/optimizer/util/pathnode.c | 15 ++++++++++-----
1 file changed, 10 insertions(+), 5 deletions(-)



Message-ID: <E1sYGGF-001gjV-53@gemulon.postgresql.org>
Permalink:  ../E1sYGGF-001gjV-53@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1sYGGF-001gjV-53@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: rguo@postgresql.org, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Simplify create_merge_append_path for clarity
  In-Reply-To: <E1sYGGF-001gjV-53@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox