From: Nathan Bossart <nathan@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Remove tab completion for CREATE UNLOGGED MATERIALIZED VIEW.
Date: Mon, 29 Jul 2024 16:34:49 +0000
Message-ID: <E1sYTKj-001lds-39@gemulon.postgresql.org> (raw)
Remove tab completion for CREATE UNLOGGED MATERIALIZED VIEW.
Commit 3bf3ab8c56 added support for unlogged materialized views,
but commit 3223b25ff7 reverted that feature before it made it into
a release. However, the latter commit left the grammar and
tab-completion support intact. This commit removes the
tab-completion support to prevent psql from recommending bogus
commands. I've opted to keep the grammar support so that the
server continues to emit a descriptive error when users try to
create unlogged matviews.
Reported-by: Daniel Westermann, px shi
Author: Dagfinn Ilmari Mannsåker
Discussion: https://postgr.es/m/ZR0P278MB092093E92263DE16734208A5D2C59%40ZR0P278MB0920.CHEP278.PROD.OUTLOOK.COM
Discussion: https://postgr.es/m/CAAccyY%2BWg1Z-9tNfSwLmuZVgGOwqU5u1OP-RWcoAr2UZGuvN_w%40mail.gmail.com
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/5c1ce1bbbe5fb8ac2fb1725a980caeed64d7a33e
Modified Files
--------------
src/bin/psql/tab-complete.c | 10 ++--------
1 file changed, 2 insertions(+), 8 deletions(-)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: nathan@postgresql.org, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Remove tab completion for CREATE UNLOGGED MATERIALIZED VIEW.
In-Reply-To: <E1sYTKj-001lds-39@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox