From: Heikki Linnakangas <heikki.linnakangas@iki.fi>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Remove dead generators for cyrillic encoding conversion tables
Date: Mon, 29 Jul 2024 17:38:41 +0000
Message-ID: <E1sYUKX-001mDN-9q@gemulon.postgresql.org> (raw)
Remove dead generators for cyrillic encoding conversion tables
These tools were used to read the koi-iso.tab, koi-win.tab, and
koi-alt.tab files, which contained the mappings between the
single-byte cyrillic encodings. However, those data files were removed
in commit 4c3c8c048d, back in 2003. These code generators have been
unused and unusable ever since.
The generated tables live in cyrillic_and_mic.c. There has been one
change to the tables since they were generated in 1999, in commit
f4b7624eb07a. So if we resurrected the original data tables, that
change would need to be taken into account.
So this code is very dead. The tables in cyrillic_and_mic.c, which
were originally generated by these tools, are now the authoritative
source for these mappings.
Reviewed-by: Tom Lane, Aleksander Alekseev
Discussion: https://www.postgresql.org/message-id/flat/a821c3dc-36ec-4cee-8b41-7ccaa17adb18@iki.fi
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/679f940740f42f2401f72a6b95dc02b9c0ab3f30
Modified Files
--------------
src/backend/utils/mb/README | 3 --
src/backend/utils/mb/iso.c | 74 ------------------------------------------
src/backend/utils/mb/win1251.c | 74 ------------------------------------------
src/backend/utils/mb/win866.c | 74 ------------------------------------------
4 files changed, 225 deletions(-)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: heikki.linnakangas@iki.fi, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Remove dead generators for cyrillic encoding conversion tables
In-Reply-To: <E1sYUKX-001mDN-9q@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox