From: Nathan Bossart <nathan@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Parse sequence type and integer metadata in dumpSequence().
Date: Wed, 31 Jul 2024 15:13:57 +0000
Message-ID: <E1sZB1Z-0023GU-Ul@gemulon.postgresql.org> (raw)
Parse sequence type and integer metadata in dumpSequence().
This commit modifies dumpSequence() to parse all the sequence
metadata into the appropriate types instead of carting around
string pointers to the PGresult data. Besides allowing us to free
the PGresult storage earlier in the function, this eliminates the
need to compare min_value and max_value to their respective
defaults as strings.
This is preparatory work for a follow-up commit that will improve
the performance of dumpSequence() in a similar manner to how commit
2329cad1b9 optimized binary_upgrade_set_pg_class_oids().
Reviewed-by: Euler Taveira
Discussion: https://postgr.es/m/20240503025140.GA1227404%40nathanxps13
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/23687e925f94e36d2d3172faa053f4540bfbb8d2
Modified Files
--------------
src/bin/pg_dump/pg_dump.c | 104 ++++++++++++++++++++++-----------------
src/tools/pgindent/typedefs.list | 1 +
2 files changed, 61 insertions(+), 44 deletions(-)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: nathan@postgresql.org, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Parse sequence type and integer metadata in dumpSequence().
In-Reply-To: <E1sZB1Z-0023GU-Ul@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox