From: Tom Lane <tgl@sss.pgh.pa.us>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Revert "Allow parallel workers to cope with a newly-created sess
Date: Thu, 01 Aug 2024 00:57:14 +0000
Message-ID: <E1sZK82-0026zE-Rn@gemulon.postgresql.org> (raw)
Revert "Allow parallel workers to cope with a newly-created session user ID."
This reverts commit 48536305370acd75c6264fcefec7fae7af8c5440.
Some buildfarm animals are failing with "cannot change
"client_encoding" during a parallel operation". It looks like
assign_client_encoding is unhappy at being asked to roll back a
client_encoding setting after a parallel worker encounters a
failure. There must be more to it though: why didn't I see this
during local testing? In any case, it's clear that moving the
RestoreGUCState() call is not as side-effect-free as I thought.
Given that the bug f5f30c22e intended to fix has gone unreported
for years, it's not something that's urgent to fix; I'm not
willing to risk messing with it further with only days to our
next release wrap.
Branch
------
REL_15_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/afbf32fa1aa87f710b623cbdf746c55b4799574e
Modified Files
--------------
src/backend/access/transam/parallel.c | 12 ++++--------
src/backend/commands/variable.c | 10 ++--------
src/test/regress/expected/select_parallel.out | 18 ------------------
src/test/regress/sql/select_parallel.sql | 9 ---------
4 files changed, 6 insertions(+), 43 deletions(-)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: tgl@sss.pgh.pa.us, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Revert "Allow parallel workers to cope with a newly-created sess
In-Reply-To: <E1sZK82-0026zE-Rn@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox