From: Peter Eisentraut <peter@eisentraut.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Add -Wmissing-variable-declarations to the standard compilation
Date: Sat, 03 Aug 2024 09:56:49 +0000
Message-ID: <E1saBVJ-002TkI-8H@gemulon.postgresql.org> (raw)
Add -Wmissing-variable-declarations to the standard compilation flags
This warning flag detects global variables not declared in header
files. This is similar to what -Wmissing-prototypes does for
functions. (More correctly, it is similar to what
-Wmissing-declarations does for functions, but -Wmissing-prototypes is
a superset of that in C.)
This flag is new in GCC 14. Clang has supported it for a while.
Several recent commits have cleaned up warnings triggered by this, so
it should now be clean.
Reviewed-by: Andres Freund <andres@anarazel.de>
Discussion: https://www.postgresql.org/message-id/flat/e0a62134-83da-4ba4-8cdb-ceb0111c95ce@eisentraut.org
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/66188912566b5614dff095ae86f4b1e06d58e875
Modified Files
--------------
configure | 49 +++++++++++++++++++++++++++++++
configure.ac | 9 ++++++
meson.build | 10 +++++++
src/Makefile.global.in | 1 +
src/interfaces/ecpg/test/Makefile.regress | 2 +-
src/interfaces/ecpg/test/meson.build | 1 +
src/makefiles/meson.build | 2 ++
src/tools/pg_bsd_indent/Makefile | 2 ++
src/tools/pg_bsd_indent/meson.build | 1 +
9 files changed, 76 insertions(+), 1 deletion(-)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: peter@eisentraut.org, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Add -Wmissing-variable-declarations to the standard compilation
In-Reply-To: <E1saBVJ-002TkI-8H@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox