pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Heikki Linnakangas <heikki.linnakangas@iki.fi>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Make fallback MD5 implementation thread-safe on big-endian syste
Date: Wed, 07 Aug 2024 07:51:31 +0000
Message-ID: <E1sbbSF-0035LF-8x@gemulon.postgresql.org> (raw)

Make fallback MD5 implementation thread-safe on big-endian systems

Replace a static scratch buffer with a local variable, because a
static buffer makes the function not thread-safe. This function is
used in client-code in libpq, so it needs to be thread-safe. It was
until commit b67b57a966, which replaced the implementation with the
one from pgcrypto.

Backpatch to v14, where we switched to the new implementation.

Reviewed-by: Robert Haas, Michael Paquier
Discussion: https://www.postgresql.org/message-id/dfa2015d-ad21-4802-a4cc-3850fc5fff3f@iki.fi

Branch
------
REL_15_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/a38f5f880d1e86fedf1616de5391df5f0d5e4239

Modified Files
--------------
src/common/md5.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)



view thread (5+ messages)  latest in thread

Message-ID: <E1sbbSF-0035LF-8x@gemulon.postgresql.org>
Permalink:  ../E1sbbSF-0035LF-8x@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1sbbSF-0035LF-8x@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: heikki.linnakangas@iki.fi, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Make fallback MD5 implementation thread-safe on big-endian syste
  In-Reply-To: <E1sbbSF-0035LF-8x@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox