From: Robert Haas <rhaas@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Improve file header comments for astramer code.
Date: Wed, 07 Aug 2024 12:56:16 +0000
Message-ID: <E1sbgDA-0037vy-JO@gemulon.postgresql.org> (raw)
Improve file header comments for astramer code.
Make it clear that "astreamer" stands for "archive streamer".
Generalize comments that still believe this code can only be used
by pg_basebackup. Add some comments explaining the asymmetry
between the gzip, lz4, and zstd astreamers, in the hopes of making
life easier for anyone who hacks on this code in the future.
Robert Haas, reviewed by Amul Sul.
Discussion: http://postgr.es/m/CAAJ_b97O2kkKVTWxt8MxDN1o-cDfbgokqtiN2yqFf48=gXpcxQ@mail.gmail.com
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/22b4a1b561f830f2af80c21450a4c05f6efbb698
Modified Files
--------------
src/fe_utils/astreamer_file.c | 4 ++++
src/fe_utils/astreamer_gzip.c | 15 +++++++++++++++
src/fe_utils/astreamer_lz4.c | 4 ++++
src/fe_utils/astreamer_zstd.c | 4 ++++
src/include/fe_utils/astreamer.h | 21 +++++++++++++++------
5 files changed, 42 insertions(+), 6 deletions(-)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: rhaas@postgresql.org, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Improve file header comments for astramer code.
In-Reply-To: <E1sbgDA-0037vy-JO@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox