pg.ddx.io pgsql-committers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
pgsql: Fix pg_rewind debug output to print the source timeline history 7+ messages / 1 participants [nested] [flat]
* pgsql: Fix pg_rewind debug output to print the source timeline history @ 2024-08-08 07:28 Heikki Linnakangas <heikki.linnakangas@iki.fi> 0 siblings, 0 replies; 7+ messages in thread From: Heikki Linnakangas @ 2024-08-08 07:28 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix pg_rewind debug output to print the source timeline history getTimelineHistory() is called twice, to read the source and the target timeline history files. However, the loop to print the file with the --debug option used the wrong variable when dealing with the source. As a result, the source's history was always printed as empty. Spotted while debugging bug #18575, but this does not fix that bug, just the debugging output. Backpatch to all supported versions. Discussion: https://www.postgresql.org/message-id/092dd515-b7b4-4fd0-8407-ceca2f02f6ec@iki.fi Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/49dc191bd1ae30180597c33e7f75a9950b896ccc Modified Files -------------- src/bin/pg_rewind/pg_rewind.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) ^ permalink raw reply [nested|flat] 7+ messages in thread
* pgsql: Fix pg_rewind debug output to print the source timeline history @ 2024-08-08 07:28 Heikki Linnakangas <heikki.linnakangas@iki.fi> 0 siblings, 0 replies; 7+ messages in thread From: Heikki Linnakangas @ 2024-08-08 07:28 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix pg_rewind debug output to print the source timeline history getTimelineHistory() is called twice, to read the source and the target timeline history files. However, the loop to print the file with the --debug option used the wrong variable when dealing with the source. As a result, the source's history was always printed as empty. Spotted while debugging bug #18575, but this does not fix that bug, just the debugging output. Backpatch to all supported versions. Discussion: https://www.postgresql.org/message-id/092dd515-b7b4-4fd0-8407-ceca2f02f6ec@iki.fi Branch ------ REL_17_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/a7bf3e66852743503eb32cb38d93c0740dcca00a Modified Files -------------- src/bin/pg_rewind/pg_rewind.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) ^ permalink raw reply [nested|flat] 7+ messages in thread
* pgsql: Fix pg_rewind debug output to print the source timeline history @ 2024-08-08 07:28 Heikki Linnakangas <heikki.linnakangas@iki.fi> 0 siblings, 0 replies; 7+ messages in thread From: Heikki Linnakangas @ 2024-08-08 07:28 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix pg_rewind debug output to print the source timeline history getTimelineHistory() is called twice, to read the source and the target timeline history files. However, the loop to print the file with the --debug option used the wrong variable when dealing with the source. As a result, the source's history was always printed as empty. Spotted while debugging bug #18575, but this does not fix that bug, just the debugging output. Backpatch to all supported versions. Discussion: https://www.postgresql.org/message-id/092dd515-b7b4-4fd0-8407-ceca2f02f6ec@iki.fi Branch ------ REL_16_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/e8240dbd86f70e268ebda57c07eb98bd80a4e6f0 Modified Files -------------- src/bin/pg_rewind/pg_rewind.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) ^ permalink raw reply [nested|flat] 7+ messages in thread
* pgsql: Fix pg_rewind debug output to print the source timeline history @ 2024-08-08 07:28 Heikki Linnakangas <heikki.linnakangas@iki.fi> 0 siblings, 0 replies; 7+ messages in thread From: Heikki Linnakangas @ 2024-08-08 07:28 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix pg_rewind debug output to print the source timeline history getTimelineHistory() is called twice, to read the source and the target timeline history files. However, the loop to print the file with the --debug option used the wrong variable when dealing with the source. As a result, the source's history was always printed as empty. Spotted while debugging bug #18575, but this does not fix that bug, just the debugging output. Backpatch to all supported versions. Discussion: https://www.postgresql.org/message-id/092dd515-b7b4-4fd0-8407-ceca2f02f6ec@iki.fi Branch ------ REL_15_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/b5a5027c9796e2958392f4682928d47b5b0d0e47 Modified Files -------------- src/bin/pg_rewind/pg_rewind.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) ^ permalink raw reply [nested|flat] 7+ messages in thread
* pgsql: Fix pg_rewind debug output to print the source timeline history @ 2024-08-08 07:28 Heikki Linnakangas <heikki.linnakangas@iki.fi> 0 siblings, 0 replies; 7+ messages in thread From: Heikki Linnakangas @ 2024-08-08 07:28 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix pg_rewind debug output to print the source timeline history getTimelineHistory() is called twice, to read the source and the target timeline history files. However, the loop to print the file with the --debug option used the wrong variable when dealing with the source. As a result, the source's history was always printed as empty. Spotted while debugging bug #18575, but this does not fix that bug, just the debugging output. Backpatch to all supported versions. Discussion: https://www.postgresql.org/message-id/092dd515-b7b4-4fd0-8407-ceca2f02f6ec@iki.fi Branch ------ REL_14_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/bb5592caceded690451869ac098b55dbb2142dfc Modified Files -------------- src/bin/pg_rewind/pg_rewind.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) ^ permalink raw reply [nested|flat] 7+ messages in thread
* pgsql: Fix pg_rewind debug output to print the source timeline history @ 2024-08-08 07:28 Heikki Linnakangas <heikki.linnakangas@iki.fi> 0 siblings, 0 replies; 7+ messages in thread From: Heikki Linnakangas @ 2024-08-08 07:28 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix pg_rewind debug output to print the source timeline history getTimelineHistory() is called twice, to read the source and the target timeline history files. However, the loop to print the file with the --debug option used the wrong variable when dealing with the source. As a result, the source's history was always printed as empty. Spotted while debugging bug #18575, but this does not fix that bug, just the debugging output. Backpatch to all supported versions. Discussion: https://www.postgresql.org/message-id/092dd515-b7b4-4fd0-8407-ceca2f02f6ec@iki.fi Branch ------ REL_13_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/c943e2aae7c59c673d502bbb243b57469be4c75f Modified Files -------------- src/bin/pg_rewind/pg_rewind.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) ^ permalink raw reply [nested|flat] 7+ messages in thread
* pgsql: Fix pg_rewind debug output to print the source timeline history @ 2024-08-08 07:28 Heikki Linnakangas <heikki.linnakangas@iki.fi> 0 siblings, 0 replies; 7+ messages in thread From: Heikki Linnakangas @ 2024-08-08 07:28 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix pg_rewind debug output to print the source timeline history getTimelineHistory() is called twice, to read the source and the target timeline history files. However, the loop to print the file with the --debug option used the wrong variable when dealing with the source. As a result, the source's history was always printed as empty. Spotted while debugging bug #18575, but this does not fix that bug, just the debugging output. Backpatch to all supported versions. Discussion: https://www.postgresql.org/message-id/092dd515-b7b4-4fd0-8407-ceca2f02f6ec@iki.fi Branch ------ REL_12_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/8b86e289f7f0db1b1b95c33c880c26393ecd414e Modified Files -------------- src/bin/pg_rewind/pg_rewind.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) ^ permalink raw reply [nested|flat] 7+ messages in thread
end of thread, other threads:[~2024-08-08 07:28 UTC | newest] Thread overview: 7+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2024-08-08 07:28 pgsql: Fix pg_rewind debug output to print the source timeline history Heikki Linnakangas <heikki.linnakangas@iki.fi> 2024-08-08 07:28 pgsql: Fix pg_rewind debug output to print the source timeline history Heikki Linnakangas <heikki.linnakangas@iki.fi> 2024-08-08 07:28 pgsql: Fix pg_rewind debug output to print the source timeline history Heikki Linnakangas <heikki.linnakangas@iki.fi> 2024-08-08 07:28 pgsql: Fix pg_rewind debug output to print the source timeline history Heikki Linnakangas <heikki.linnakangas@iki.fi> 2024-08-08 07:28 pgsql: Fix pg_rewind debug output to print the source timeline history Heikki Linnakangas <heikki.linnakangas@iki.fi> 2024-08-08 07:28 pgsql: Fix pg_rewind debug output to print the source timeline history Heikki Linnakangas <heikki.linnakangas@iki.fi> 2024-08-08 07:28 pgsql: Fix pg_rewind debug output to print the source timeline history Heikki Linnakangas <heikki.linnakangas@iki.fi>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox