From: Heikki Linnakangas <heikki.linnakangas@iki.fi>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Fix pg_rewind debug output to print the source timeline history
Date: Thu, 08 Aug 2024 07:28:40 +0000
Message-ID: <E1sbxZg-003EyY-7C@gemulon.postgresql.org> (raw)
Fix pg_rewind debug output to print the source timeline history
getTimelineHistory() is called twice, to read the source and the
target timeline history files. However, the loop to print the file
with the --debug option used the wrong variable when dealing with the
source. As a result, the source's history was always printed as empty.
Spotted while debugging bug #18575, but this does not fix that bug,
just the debugging output. Backpatch to all supported versions.
Discussion: https://www.postgresql.org/message-id/092dd515-b7b4-4fd0-8407-ceca2f02f6ec@iki.fi
Branch
------
REL_12_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/8b86e289f7f0db1b1b95c33c880c26393ecd414e
Modified Files
--------------
src/bin/pg_rewind/pg_rewind.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: heikki.linnakangas@iki.fi, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Fix pg_rewind debug output to print the source timeline history
In-Reply-To: <E1sbxZg-003EyY-7C@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox