pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Alvaro Herrera <alvherre@alvh.no-ip.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: libpq: Trace all messages received from the server
Date: Fri, 16 Aug 2024 17:24:02 +0000
Message-ID: <E1sf0gE-0000dZ-6N@gemulon.postgresql.org> (raw)

libpq: Trace all messages received from the server

Not all messages that libpq received from the server would be sent
through our message tracing logic.  This commit tries to fix that by
introducing a new function pqParseDone which make it harder to forget
about doing so.

The messages that we now newly send through our tracing logic are:

- CopyData (received by COPY TO STDOUT)
- Authentication requests
- NegotiateProtocolVersion
- Some ErrorResponse messages during connection startup
- ReadyForQuery when received after a FunctionCall message

Author: Jelte Fennema-Nio <postgres@jeltef.nl>
Discussion: https://postgr.es/m/CAGECzQSoPHtZ4xe0raJ6FYSEiPPS+YWXBhOGo+Y1YecLgknF3g@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/b8b3f861fbd7ff40055225ec48cec97df925ff04

Modified Files
--------------
src/interfaces/libpq/fe-auth.c      | 21 ++++++++++++
src/interfaces/libpq/fe-connect.c   | 12 ++++---
src/interfaces/libpq/fe-misc.c      | 15 ++++++++
src/interfaces/libpq/fe-protocol3.c | 38 +++++++++------------
src/interfaces/libpq/fe-trace.c     | 68 ++++++++++++++++++++++++++++++++++---
src/interfaces/libpq/libpq-int.h    |  1 +
6 files changed, 124 insertions(+), 31 deletions(-)



Message-ID: <E1sf0gE-0000dZ-6N@gemulon.postgresql.org>
Permalink:  ../E1sf0gE-0000dZ-6N@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1sf0gE-0000dZ-6N@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: alvherre@alvh.no-ip.org, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: libpq: Trace all messages received from the server
  In-Reply-To: <E1sf0gE-0000dZ-6N@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox