pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tomas Vondra <tomas.vondra@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Explain dropdb can't use syscache because of TOAST
Date: Mon, 19 Aug 2024 12:00:58 +0000
Message-ID: <E1sg14E-000QFR-Np@gemulon.postgresql.org> (raw)

Explain dropdb can't use syscache because of TOAST

Add a comment explaining dropdb() can't rely on syscache. The issue with
flattened rows was fixed by commit 0f92b230f88b, but better to have
a clear explanation why the systable scan is necessary. The other places
doing in-place updates on pg_database have the same comment.

Suggestion and patch by Yugo Nagata. Backpatch to 12, same as the fix.

Author: Yugo Nagata
Backpatch-through: 12
Discussion: https://postgr.es/m/CAJTYsWWNkCt+-UnMhg=BiCD3Mh8c2JdHLofPxsW3m2dkDFw8RA@mail.gmail.com

Branch
------
REL_15_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/e498d22e21358e196c1db9b5f1300eae667ea2bd

Modified Files
--------------
src/backend/commands/dbcommands.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)



view thread (7+ messages)  latest in thread

Message-ID: <E1sg14E-000QFR-Np@gemulon.postgresql.org>
Permalink:  ../E1sg14E-000QFR-Np@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1sg14E-000QFR-Np@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: tomas.vondra@postgresql.org, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Explain dropdb can't use syscache because of TOAST
  In-Reply-To: <E1sg14E-000QFR-Np@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox