pg.ddx.io pgsql-committers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
pgsql: Explain dropdb can't use syscache because of TOAST 7+ messages / 1 participants [nested] [flat]
* pgsql: Explain dropdb can't use syscache because of TOAST @ 2024-08-19 11:59 Tomas Vondra <tomas.vondra@postgresql.org> 0 siblings, 0 replies; 7+ messages in thread From: Tomas Vondra @ 2024-08-19 11:59 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Explain dropdb can't use syscache because of TOAST Add a comment explaining dropdb() can't rely on syscache. The issue with flattened rows was fixed by commit 0f92b230f88b, but better to have a clear explanation why the systable scan is necessary. The other places doing in-place updates on pg_database have the same comment. Suggestion and patch by Yugo Nagata. Backpatch to 12, same as the fix. Author: Yugo Nagata Backpatch-through: 12 Discussion: https://postgr.es/m/CAJTYsWWNkCt+-UnMhg=BiCD3Mh8c2JdHLofPxsW3m2dkDFw8RA@mail.gmail.com Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/5cb902e9d5a99a0e1a2c9098555447e097102e39 Modified Files -------------- src/backend/commands/dbcommands.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) ^ permalink raw reply [nested|flat] 7+ messages in thread
* pgsql: Explain dropdb can't use syscache because of TOAST @ 2024-08-19 11:59 Tomas Vondra <tomas.vondra@postgresql.org> 0 siblings, 0 replies; 7+ messages in thread From: Tomas Vondra @ 2024-08-19 11:59 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Explain dropdb can't use syscache because of TOAST Add a comment explaining dropdb() can't rely on syscache. The issue with flattened rows was fixed by commit 0f92b230f88b, but better to have a clear explanation why the systable scan is necessary. The other places doing in-place updates on pg_database have the same comment. Suggestion and patch by Yugo Nagata. Backpatch to 12, same as the fix. Author: Yugo Nagata Backpatch-through: 12 Discussion: https://postgr.es/m/CAJTYsWWNkCt+-UnMhg=BiCD3Mh8c2JdHLofPxsW3m2dkDFw8RA@mail.gmail.com Branch ------ REL_17_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/de8770b47f1f763378d9d130d69e3a7b8a54684a Modified Files -------------- src/backend/commands/dbcommands.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) ^ permalink raw reply [nested|flat] 7+ messages in thread
* pgsql: Explain dropdb can't use syscache because of TOAST @ 2024-08-19 12:00 Tomas Vondra <tomas.vondra@postgresql.org> 0 siblings, 0 replies; 7+ messages in thread From: Tomas Vondra @ 2024-08-19 12:00 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Explain dropdb can't use syscache because of TOAST Add a comment explaining dropdb() can't rely on syscache. The issue with flattened rows was fixed by commit 0f92b230f88b, but better to have a clear explanation why the systable scan is necessary. The other places doing in-place updates on pg_database have the same comment. Suggestion and patch by Yugo Nagata. Backpatch to 12, same as the fix. Author: Yugo Nagata Backpatch-through: 12 Discussion: https://postgr.es/m/CAJTYsWWNkCt+-UnMhg=BiCD3Mh8c2JdHLofPxsW3m2dkDFw8RA@mail.gmail.com Branch ------ REL_16_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/f6991cafa36ee8cb943a34f13452fd166b7907c2 Modified Files -------------- src/backend/commands/dbcommands.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) ^ permalink raw reply [nested|flat] 7+ messages in thread
* pgsql: Explain dropdb can't use syscache because of TOAST @ 2024-08-19 12:00 Tomas Vondra <tomas.vondra@postgresql.org> 0 siblings, 0 replies; 7+ messages in thread From: Tomas Vondra @ 2024-08-19 12:00 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Explain dropdb can't use syscache because of TOAST Add a comment explaining dropdb() can't rely on syscache. The issue with flattened rows was fixed by commit 0f92b230f88b, but better to have a clear explanation why the systable scan is necessary. The other places doing in-place updates on pg_database have the same comment. Suggestion and patch by Yugo Nagata. Backpatch to 12, same as the fix. Author: Yugo Nagata Backpatch-through: 12 Discussion: https://postgr.es/m/CAJTYsWWNkCt+-UnMhg=BiCD3Mh8c2JdHLofPxsW3m2dkDFw8RA@mail.gmail.com Branch ------ REL_15_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/e498d22e21358e196c1db9b5f1300eae667ea2bd Modified Files -------------- src/backend/commands/dbcommands.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) ^ permalink raw reply [nested|flat] 7+ messages in thread
* pgsql: Explain dropdb can't use syscache because of TOAST @ 2024-08-19 12:01 Tomas Vondra <tomas.vondra@postgresql.org> 0 siblings, 0 replies; 7+ messages in thread From: Tomas Vondra @ 2024-08-19 12:01 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Explain dropdb can't use syscache because of TOAST Add a comment explaining dropdb() can't rely on syscache. The issue with flattened rows was fixed by commit 0f92b230f88b, but better to have a clear explanation why the systable scan is necessary. The other places doing in-place updates on pg_database have the same comment. Suggestion and patch by Yugo Nagata. Backpatch to 12, same as the fix. Author: Yugo Nagata Backpatch-through: 12 Discussion: https://postgr.es/m/CAJTYsWWNkCt+-UnMhg=BiCD3Mh8c2JdHLofPxsW3m2dkDFw8RA@mail.gmail.com Branch ------ REL_14_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/3acbe198e2ad0f7d790d04f87c662ee26738536a Modified Files -------------- src/backend/commands/dbcommands.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) ^ permalink raw reply [nested|flat] 7+ messages in thread
* pgsql: Explain dropdb can't use syscache because of TOAST @ 2024-08-19 12:01 Tomas Vondra <tomas.vondra@postgresql.org> 0 siblings, 0 replies; 7+ messages in thread From: Tomas Vondra @ 2024-08-19 12:01 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Explain dropdb can't use syscache because of TOAST Add a comment explaining dropdb() can't rely on syscache. The issue with flattened rows was fixed by commit 0f92b230f88b, but better to have a clear explanation why the systable scan is necessary. The other places doing in-place updates on pg_database have the same comment. Suggestion and patch by Yugo Nagata. Backpatch to 12, same as the fix. Author: Yugo Nagata Backpatch-through: 12 Discussion: https://postgr.es/m/CAJTYsWWNkCt+-UnMhg=BiCD3Mh8c2JdHLofPxsW3m2dkDFw8RA@mail.gmail.com Branch ------ REL_13_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/4e7531fda587c35a4ee0fa2e5fdf90b0914a1685 Modified Files -------------- src/backend/commands/dbcommands.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) ^ permalink raw reply [nested|flat] 7+ messages in thread
* pgsql: Explain dropdb can't use syscache because of TOAST @ 2024-08-19 12:01 Tomas Vondra <tomas.vondra@postgresql.org> 0 siblings, 0 replies; 7+ messages in thread From: Tomas Vondra @ 2024-08-19 12:01 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Explain dropdb can't use syscache because of TOAST Add a comment explaining dropdb() can't rely on syscache. The issue with flattened rows was fixed by commit 0f92b230f88b, but better to have a clear explanation why the systable scan is necessary. The other places doing in-place updates on pg_database have the same comment. Suggestion and patch by Yugo Nagata. Backpatch to 12, same as the fix. Author: Yugo Nagata Backpatch-through: 12 Discussion: https://postgr.es/m/CAJTYsWWNkCt+-UnMhg=BiCD3Mh8c2JdHLofPxsW3m2dkDFw8RA@mail.gmail.com Branch ------ REL_12_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/9d42627bcaffb34d4c165a4618583a81db67c48d Modified Files -------------- src/backend/commands/dbcommands.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) ^ permalink raw reply [nested|flat] 7+ messages in thread
end of thread, other threads:[~2024-08-19 12:01 UTC | newest] Thread overview: 7+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2024-08-19 11:59 pgsql: Explain dropdb can't use syscache because of TOAST Tomas Vondra <tomas.vondra@postgresql.org> 2024-08-19 11:59 pgsql: Explain dropdb can't use syscache because of TOAST Tomas Vondra <tomas.vondra@postgresql.org> 2024-08-19 12:00 pgsql: Explain dropdb can't use syscache because of TOAST Tomas Vondra <tomas.vondra@postgresql.org> 2024-08-19 12:00 pgsql: Explain dropdb can't use syscache because of TOAST Tomas Vondra <tomas.vondra@postgresql.org> 2024-08-19 12:01 pgsql: Explain dropdb can't use syscache because of TOAST Tomas Vondra <tomas.vondra@postgresql.org> 2024-08-19 12:01 pgsql: Explain dropdb can't use syscache because of TOAST Tomas Vondra <tomas.vondra@postgresql.org> 2024-08-19 12:01 pgsql: Explain dropdb can't use syscache because of TOAST Tomas Vondra <tomas.vondra@postgresql.org>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox