pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Alvaro Herrera <alvherre@alvh.no-ip.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Add injection-point test for new multixact CV usage
Date: Tue, 20 Aug 2024 18:35:05 +0000
Message-ID: <E1sgThA-000dou-TV@gemulon.postgresql.org> (raw)

Add injection-point test for new multixact CV usage

Before commit a0e0fb1ba56f, multixact.c contained a case in the
multixact-read path where it would loop sleeping 1ms each time until
another multixact-create path completed, which was uncovered by any
tests.  That commit changed the code to rely on a condition variable
instead.  Add a test now, which relies on injection points and "loading"
thereof (because of it being in a critical section), per commit
4b211003ecc2.

Author: Andrey Borodin <x4mmm@yandex-team.ru>
Reviewed-by: Michaƫl Paquier <michael@paquier.xyz>
Discussion: https://postgr.es/m/0925F9A9-4D53-4B27-A87E-3D83A757B0E0@yandex-team.ru

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/768a9fd5535fddb781088b6f83132b9a1b1f5bd3

Modified Files
--------------
src/backend/access/transam/multixact.c        |   5 ++
src/test/modules/test_slru/Makefile           |   7 +-
src/test/modules/test_slru/meson.build        |   9 ++
src/test/modules/test_slru/t/001_multixact.pl | 124 ++++++++++++++++++++++++++
src/test/modules/test_slru/test_multixact.c   |  57 ++++++++++++
src/test/modules/test_slru/test_slru--1.0.sql |   6 ++
6 files changed, 207 insertions(+), 1 deletion(-)



view thread (3+ messages)  latest in thread

Message-ID: <E1sgThA-000dou-TV@gemulon.postgresql.org>
Permalink:  ../E1sgThA-000dou-TV@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1sgThA-000dou-TV@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: alvherre@alvh.no-ip.org, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Add injection-point test for new multixact CV usage
  In-Reply-To: <E1sgThA-000dou-TV@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox