From: Jeff Davis <jdavis@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Improve configure error for ICU libraries if pkg-config is absen
Date: Tue, 20 Aug 2024 19:28:35 +0000
Message-ID: <E1sgUWx-000ePe-CG@gemulon.postgresql.org> (raw)
Improve configure error for ICU libraries if pkg-config is absent.
If pkg-config is not installed, the ICU libraries cannot be found, but
the custom configure error message did not mention this. This might
lead to confusion about the actual problem. To improve this, remove
the explicit error message and rely on PKG_CHECK_MODULES' generic
error message.
Author: Michael Banck
Reported-by: Holger Jakobs
Discussion: https://postgr.es/m/ccd579ed-4949-d3de-ab13-9e6456fd2caf%40jakobs.com
Discussion: https://postgr.es/m/66b5d05c.050a0220.7c8ce.a951@mx.google.com
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/0fb0f689331cb0c00348aab752dced30493a6672
Modified Files
--------------
configure | 30 ++++++++++++++++++++++--------
configure.ac | 6 +-----
2 files changed, 23 insertions(+), 13 deletions(-)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: jdavis@postgresql.org, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Improve configure error for ICU libraries if pkg-config is absen
In-Reply-To: <E1sgUWx-000ePe-CG@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox