From: Michael Paquier <michael@paquier.xyz>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Remove _PG_fini()
Date: Tue, 20 Aug 2024 22:26:00 +0000
Message-ID: <E1sgXIe-000fdB-LG@gemulon.postgresql.org> (raw)
Remove _PG_fini()
ab02d702ef08 has removed from the backend the code able to support the
unloading of modules, because this has never worked. This removes the
last references to _PG_fini(), that could be used as a callback for
modules to manipulate the stack when unloading a library.
The test module ldap_password_func had the idea to declare it, doing
nothing. The function declaration in fmgr.h is gone.
It was left around in 2022 to avoid breaking extension code, but at this
stage there are also benefits in letting extension developers know that
keeping the unloading code is pointless and this move leads to less
maintenance.
Reviewed-by: Tom Lane, Heikki Linnakangas
Discussion: https://postgr.es/m/ZsQfi0AUJoMF6NSd@paquier.xyz
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/15c1abd97710d74672e55d53148a0606baa91d18
Modified Files
--------------
src/include/fmgr.h | 11 +++++------
src/test/modules/ldap_password_func/ldap_password_func.c | 7 -------
2 files changed, 5 insertions(+), 13 deletions(-)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: michael@paquier.xyz, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Remove _PG_fini()
In-Reply-To: <E1sgXIe-000fdB-LG@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox