From: Robert Haas <rhaas@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Show number of disabled nodes in EXPLAIN ANALYZE output.
Date: Wed, 21 Aug 2024 14:24:59 +0000
Message-ID: <E1sgmGh-000mPc-1E@gemulon.postgresql.org> (raw)
Show number of disabled nodes in EXPLAIN ANALYZE output.
Now that disable_cost is not included in the cost estimate, there's
no visible sign in EXPLAIN output of which plan nodes are disabled.
Fix that by propagating the number of disabled nodes from Path to
Plan, and then showing it in the EXPLAIN output.
There is some question about whether this is a desirable change.
While I personally believe that it is, it seems best to make it a
separate commit, in case we decide to back out just this part, or
rework it.
Reviewed by Andres Freund, Heikki Linnakangas, and David Rowley.
Discussion: http://postgr.es/m/CA+TgmoZ_+MS+o6NeGK2xyBv-xM+w1AfFVuHE4f_aq6ekHv7YSQ@mail.gmail.com
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/c01743aa4866e13da2c54e44010abc6d5f986363
Modified Files
--------------
src/backend/commands/explain.c | 4 ++++
src/backend/optimizer/plan/createplan.c | 8 ++++++--
src/include/nodes/plannodes.h | 1 +
src/test/regress/expected/aggregates.out | 21 ++++++++++++++++++---
src/test/regress/expected/btree_index.out | 4 +++-
src/test/regress/expected/collate.icu.utf8.out | 6 ++++--
src/test/regress/expected/incremental_sort.out | 5 ++++-
src/test/regress/expected/inherit.out | 4 +++-
src/test/regress/expected/join.out | 4 +++-
src/test/regress/expected/memoize.out | 8 ++++++--
src/test/regress/expected/select_parallel.out | 6 +++++-
src/test/regress/expected/union.out | 3 ++-
12 files changed, 59 insertions(+), 15 deletions(-)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: rhaas@postgresql.org, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Show number of disabled nodes in EXPLAIN ANALYZE output.
In-Reply-To: <E1sgmGh-000mPc-1E@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox