pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Peter Eisentraut <peter@eisentraut.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Remove a couple of strerror() calls
Date: Wed, 04 Sep 2024 12:52:58 +0000
Message-ID: <E1slpVJ-0006p9-Tu@gemulon.postgresql.org> (raw)

Remove a couple of strerror() calls

Change to using %m in the error message string.  We need to be a bit
careful here to preserve errno until we need to print it.

This change avoids the use of not-thread-safe strerror() and unifies
some error message strings, and maybe makes the code appear more
consistent.

Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us>
Discussion: https://www.postgresql.org/message-id/flat/daa87d79-c044-46c4-8458-8d77241ed7b0%40eisentraut.org

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/82b07eba9e8b863cc05adb7e53a86ff02b51d888

Modified Files
--------------
src/backend/libpq/hba.c | 12 ++++++++----
1 file changed, 8 insertions(+), 4 deletions(-)



Message-ID: <E1slpVJ-0006p9-Tu@gemulon.postgresql.org>
Permalink:  ../E1slpVJ-0006p9-Tu@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1slpVJ-0006p9-Tu@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: peter@eisentraut.org, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Remove a couple of strerror() calls
  In-Reply-To: <E1slpVJ-0006p9-Tu@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox