pg.ddx.io pgsql-committers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
pgsql: Fix incorrect pg_stat_io output on 32-bit machines. 3+ messages / 1 participants [nested] [flat]
* pgsql: Fix incorrect pg_stat_io output on 32-bit machines. @ 2024-09-06 15:58 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 3+ messages in thread From: Tom Lane @ 2024-09-06 15:58 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix incorrect pg_stat_io output on 32-bit machines. pg_stat_get_io() applied TimestampTzGetDatum twice to the stat_reset_timestamp value. On 64-bit builds that's harmless because TimestampTzGetDatum is a no-op, but on 32-bit builds it results in displaying garbage in the stats_reset column of the pg_stat_io view. Bug dates to commit a9c70b46d which introduced pg_stat_io, so back-patch to v16 where that came in. Bertrand Drouvot Discussion: https://postgr.es/m/Ztrd+XcPTz1zorkg@ip-10-97-1-34.eu-west-3.compute.internal Branch ------ REL_16_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/dd20f950d4a37da3e71684f254fcdf4317b752b5 Modified Files -------------- src/backend/utils/adt/pgstatfuncs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) ^ permalink raw reply [nested|flat] 3+ messages in thread
* pgsql: Fix incorrect pg_stat_io output on 32-bit machines. @ 2024-09-06 15:58 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 3+ messages in thread From: Tom Lane @ 2024-09-06 15:58 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix incorrect pg_stat_io output on 32-bit machines. pg_stat_get_io() applied TimestampTzGetDatum twice to the stat_reset_timestamp value. On 64-bit builds that's harmless because TimestampTzGetDatum is a no-op, but on 32-bit builds it results in displaying garbage in the stats_reset column of the pg_stat_io view. Bug dates to commit a9c70b46d which introduced pg_stat_io, so back-patch to v16 where that came in. Bertrand Drouvot Discussion: https://postgr.es/m/Ztrd+XcPTz1zorkg@ip-10-97-1-34.eu-west-3.compute.internal Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/129a2f6679fd8891384016b6e2cde6cefda22a7d Modified Files -------------- src/backend/utils/adt/pgstatfuncs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) ^ permalink raw reply [nested|flat] 3+ messages in thread
* pgsql: Fix incorrect pg_stat_io output on 32-bit machines. @ 2024-09-06 15:58 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 3+ messages in thread From: Tom Lane @ 2024-09-06 15:58 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix incorrect pg_stat_io output on 32-bit machines. pg_stat_get_io() applied TimestampTzGetDatum twice to the stat_reset_timestamp value. On 64-bit builds that's harmless because TimestampTzGetDatum is a no-op, but on 32-bit builds it results in displaying garbage in the stats_reset column of the pg_stat_io view. Bug dates to commit a9c70b46d which introduced pg_stat_io, so back-patch to v16 where that came in. Bertrand Drouvot Discussion: https://postgr.es/m/Ztrd+XcPTz1zorkg@ip-10-97-1-34.eu-west-3.compute.internal Branch ------ REL_17_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/e69030cb5178347d499bbc549213e950064564fa Modified Files -------------- src/backend/utils/adt/pgstatfuncs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) ^ permalink raw reply [nested|flat] 3+ messages in thread
end of thread, other threads:[~2024-09-06 15:58 UTC | newest] Thread overview: 3+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2024-09-06 15:58 pgsql: Fix incorrect pg_stat_io output on 32-bit machines. Tom Lane <tgl@sss.pgh.pa.us> 2024-09-06 15:58 pgsql: Fix incorrect pg_stat_io output on 32-bit machines. Tom Lane <tgl@sss.pgh.pa.us> 2024-09-06 15:58 pgsql: Fix incorrect pg_stat_io output on 32-bit machines. Tom Lane <tgl@sss.pgh.pa.us>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox