pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Fix incorrect pg_stat_io output on 32-bit machines.
Date: Fri, 06 Sep 2024 15:58:30 +0000
Message-ID: <E1smbLx-000QPF-UO@gemulon.postgresql.org> (raw)

Fix incorrect pg_stat_io output on 32-bit machines.

pg_stat_get_io() applied TimestampTzGetDatum twice to the
stat_reset_timestamp value.  On 64-bit builds that's harmless because
TimestampTzGetDatum is a no-op, but on 32-bit builds it results in
displaying garbage in the stats_reset column of the pg_stat_io view.

Bug dates to commit a9c70b46d which introduced pg_stat_io, so
back-patch to v16 where that came in.

Bertrand Drouvot

Discussion: https://postgr.es/m/Ztrd+XcPTz1zorkg@ip-10-97-1-34.eu-west-3.compute.internal

Branch
------
REL_17_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/e69030cb5178347d499bbc549213e950064564fa

Modified Files
--------------
src/backend/utils/adt/pgstatfuncs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)



view thread (3+ messages)

Message-ID: <E1smbLx-000QPF-UO@gemulon.postgresql.org>
Permalink:  ../E1smbLx-000QPF-UO@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1smbLx-000QPF-UO@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Fix incorrect pg_stat_io output on 32-bit machines.
  In-Reply-To: <E1smbLx-000QPF-UO@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox