pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tomas Vondra <tomas.vondra@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Add PG_TEST_PG_COMBINEBACKUP_MODE to CI tasks
Date: Tue, 10 Sep 2024 14:30:56 +0000
Message-ID: <E1so1tQ-000Rxl-AL@gemulon.postgresql.org> (raw)

Add PG_TEST_PG_COMBINEBACKUP_MODE to CI tasks

The environment variable PG_TEST_PG_COMBINEBACKUP_MODE has been
available since 35a7b288b975, but was not set by any built-in CI tasks.
This commit modifies two of the CI tasks to use the alternative modes,
to exercise the pg_combinebackup code.

The Linux task uses --copy-file-range, macOS uses --clone.

This is not an exhaustive test of combinations. The supported modes
depend on the operating system and filesystem, and it would be nice to
test all supported combinations. Right now we have just one task for
each OS, and it doesn't seem worth adding more just for this.

Reported-by: Peter Eisentraut
Reviewed-by: Peter Eisentraut
Discussion: https://postgr.es/m/48da4a1f-ccd9-4988-9622-24f37b1de2b4%40eisentraut.org

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/861086493faa9ca5468cc50dd20975ee6c042ffe

Modified Files
--------------
.cirrus.tasks.yml | 2 ++
1 file changed, 2 insertions(+)



Message-ID: <E1so1tQ-000Rxl-AL@gemulon.postgresql.org>
Permalink:  ../E1so1tQ-000Rxl-AL@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1so1tQ-000Rxl-AL@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: tomas.vondra@postgresql.org, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Add PG_TEST_PG_COMBINEBACKUP_MODE to CI tasks
  In-Reply-To: <E1so1tQ-000Rxl-AL@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox