From: Tom Lane <tgl@sss.pgh.pa.us>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Fix some whitespace issues in XMLSERIALIZE(... INDENT).
Date: Tue, 10 Sep 2024 20:20:38 +0000
Message-ID: <E1so7Lq-000UEH-P9@gemulon.postgresql.org> (raw)
Fix some whitespace issues in XMLSERIALIZE(... INDENT).
We must drop whitespace while parsing the input, else libxml2
will include "blank" nodes that interfere with the desired
indentation behavior. The end result is that we didn't indent
nodes separated by whitespace.
Also, it seems that libxml2 may add a trailing newline when working
in DOCUMENT mode. This is semantically insignificant, so strip it.
This is in the gray area between being a bug fix and a definition
change. However, the INDENT option is still pretty new (since v16),
so I think we can get away with changing this in stable branches.
Hence, back-patch to v16.
Jim Jones
Discussion: https://postgr.es/m/872865a8-548b-48e1-bfcd-4e38e672c1e4@uni-muenster.de
Branch
------
REL_17_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/946f150aa180ec61d37d7a41e43765b4c25ca784
Modified Files
--------------
src/backend/utils/adt/xml.c | 27 ++++++++++++++++++++++++---
src/test/regress/expected/xml.out | 33 +++++++++++++++++++++++----------
src/test/regress/expected/xml_1.out | 11 +++++++++++
src/test/regress/expected/xml_2.out | 33 +++++++++++++++++++++++----------
src/test/regress/sql/xml.sql | 3 +++
5 files changed, 84 insertions(+), 23 deletions(-)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: tgl@sss.pgh.pa.us, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Fix some whitespace issues in XMLSERIALIZE(... INDENT).
In-Reply-To: <E1so7Lq-000UEH-P9@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox