pg.ddx.io pgsql-committers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
pgsql: Reintroduce support for sequences in pgstattuple and pageinspect 7+ messages / 1 participants [nested] [flat]
* pgsql: Reintroduce support for sequences in pgstattuple and pageinspect @ 2024-09-12 21:33 Nathan Bossart <nathan@postgresql.org> 0 siblings, 0 replies; 7+ messages in thread From: Nathan Bossart @ 2024-09-12 21:33 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Reintroduce support for sequences in pgstattuple and pageinspect. Commit 4b82664156 restricted a number of functions provided by contrib modules to only relations that use the "heap" table access method. Sequences always use this table access method, but they do not advertise as such in the pg_class system catalog, so the aforementioned commit also (presumably unintentionally) removed support for sequences from some of these functions. This commit reintroduces said support for sequences to these functions and adds a couple of relevant tests. Co-authored-by: Ayush Vatsa Reviewed-by: Robert Haas, Michael Paquier, Matthias van de Meent Discussion: https://postgr.es/m/CACX%2BKaP3i%2Bi9tdPLjF5JCHVv93xobEdcd_eB%2B638VDvZ3i%3DcQA%40mail.gmail.com Backpatch-through: 12 Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/05036a3155c1e8d21500b5ecbbc2f8fbeb4aea66 Modified Files -------------- contrib/pageinspect/expected/page.out | 9 +++++++++ contrib/pageinspect/heapfuncs.c | 6 +++++- contrib/pageinspect/sql/page.sql | 5 +++++ contrib/pgstattuple/expected/pgstattuple.out | 25 +++++++++++++++++++++++++ contrib/pgstattuple/pgstattuple.c | 6 +++++- contrib/pgstattuple/sql/pgstattuple.sql | 12 ++++++++++++ 6 files changed, 61 insertions(+), 2 deletions(-) ^ permalink raw reply [nested|flat] 7+ messages in thread
* pgsql: Reintroduce support for sequences in pgstattuple and pageinspect @ 2024-09-12 21:33 Nathan Bossart <nathan@postgresql.org> 0 siblings, 0 replies; 7+ messages in thread From: Nathan Bossart @ 2024-09-12 21:33 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Reintroduce support for sequences in pgstattuple and pageinspect. Commit 4b82664156 restricted a number of functions provided by contrib modules to only relations that use the "heap" table access method. Sequences always use this table access method, but they do not advertise as such in the pg_class system catalog, so the aforementioned commit also (presumably unintentionally) removed support for sequences from some of these functions. This commit reintroduces said support for sequences to these functions and adds a couple of relevant tests. Co-authored-by: Ayush Vatsa Reviewed-by: Robert Haas, Michael Paquier, Matthias van de Meent Discussion: https://postgr.es/m/CACX%2BKaP3i%2Bi9tdPLjF5JCHVv93xobEdcd_eB%2B638VDvZ3i%3DcQA%40mail.gmail.com Backpatch-through: 12 Branch ------ REL_17_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/6ea7f04b73661a0141fdcbfb590961b02832114d Modified Files -------------- contrib/pageinspect/expected/page.out | 9 +++++++++ contrib/pageinspect/heapfuncs.c | 6 +++++- contrib/pageinspect/sql/page.sql | 5 +++++ contrib/pgstattuple/expected/pgstattuple.out | 25 +++++++++++++++++++++++++ contrib/pgstattuple/pgstattuple.c | 6 +++++- contrib/pgstattuple/sql/pgstattuple.sql | 12 ++++++++++++ 6 files changed, 61 insertions(+), 2 deletions(-) ^ permalink raw reply [nested|flat] 7+ messages in thread
* pgsql: Reintroduce support for sequences in pgstattuple and pageinspect @ 2024-09-12 21:33 Nathan Bossart <nathan@postgresql.org> 0 siblings, 0 replies; 7+ messages in thread From: Nathan Bossart @ 2024-09-12 21:33 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Reintroduce support for sequences in pgstattuple and pageinspect. Commit 4b82664156 restricted a number of functions provided by contrib modules to only relations that use the "heap" table access method. Sequences always use this table access method, but they do not advertise as such in the pg_class system catalog, so the aforementioned commit also (presumably unintentionally) removed support for sequences from some of these functions. This commit reintroduces said support for sequences to these functions and adds a couple of relevant tests. Co-authored-by: Ayush Vatsa Reviewed-by: Robert Haas, Michael Paquier, Matthias van de Meent Discussion: https://postgr.es/m/CACX%2BKaP3i%2Bi9tdPLjF5JCHVv93xobEdcd_eB%2B638VDvZ3i%3DcQA%40mail.gmail.com Backpatch-through: 12 Branch ------ REL_16_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/2bd4c06bba8ce1264ae3d5810b6aea1bfacbadf7 Modified Files -------------- contrib/pageinspect/expected/page.out | 9 +++++++++ contrib/pageinspect/heapfuncs.c | 6 +++++- contrib/pageinspect/sql/page.sql | 5 +++++ contrib/pgstattuple/expected/pgstattuple.out | 25 +++++++++++++++++++++++++ contrib/pgstattuple/pgstattuple.c | 6 +++++- contrib/pgstattuple/sql/pgstattuple.sql | 12 ++++++++++++ 6 files changed, 61 insertions(+), 2 deletions(-) ^ permalink raw reply [nested|flat] 7+ messages in thread
* pgsql: Reintroduce support for sequences in pgstattuple and pageinspect @ 2024-09-12 21:33 Nathan Bossart <nathan@postgresql.org> 0 siblings, 0 replies; 7+ messages in thread From: Nathan Bossart @ 2024-09-12 21:33 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Reintroduce support for sequences in pgstattuple and pageinspect. Commit 4b82664156 restricted a number of functions provided by contrib modules to only relations that use the "heap" table access method. Sequences always use this table access method, but they do not advertise as such in the pg_class system catalog, so the aforementioned commit also (presumably unintentionally) removed support for sequences from some of these functions. This commit reintroduces said support for sequences to these functions and adds a couple of relevant tests. Co-authored-by: Ayush Vatsa Reviewed-by: Robert Haas, Michael Paquier, Matthias van de Meent Discussion: https://postgr.es/m/CACX%2BKaP3i%2Bi9tdPLjF5JCHVv93xobEdcd_eB%2B638VDvZ3i%3DcQA%40mail.gmail.com Backpatch-through: 12 Branch ------ REL_15_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/e03042a7003dcf0e966f0c6ea3ecf128455bf2b3 Modified Files -------------- contrib/pageinspect/expected/page.out | 9 +++++++++ contrib/pageinspect/heapfuncs.c | 6 +++++- contrib/pageinspect/sql/page.sql | 5 +++++ contrib/pgstattuple/expected/pgstattuple.out | 25 +++++++++++++++++++++++++ contrib/pgstattuple/pgstattuple.c | 6 +++++- contrib/pgstattuple/sql/pgstattuple.sql | 12 ++++++++++++ 6 files changed, 61 insertions(+), 2 deletions(-) ^ permalink raw reply [nested|flat] 7+ messages in thread
* pgsql: Reintroduce support for sequences in pgstattuple and pageinspect @ 2024-09-12 21:33 Nathan Bossart <nathan@postgresql.org> 0 siblings, 0 replies; 7+ messages in thread From: Nathan Bossart @ 2024-09-12 21:33 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Reintroduce support for sequences in pgstattuple and pageinspect. Commit 4b82664156 restricted a number of functions provided by contrib modules to only relations that use the "heap" table access method. Sequences always use this table access method, but they do not advertise as such in the pg_class system catalog, so the aforementioned commit also (presumably unintentionally) removed support for sequences from some of these functions. This commit reintroduces said support for sequences to these functions and adds a couple of relevant tests. Co-authored-by: Ayush Vatsa Reviewed-by: Robert Haas, Michael Paquier, Matthias van de Meent Discussion: https://postgr.es/m/CACX%2BKaP3i%2Bi9tdPLjF5JCHVv93xobEdcd_eB%2B638VDvZ3i%3DcQA%40mail.gmail.com Backpatch-through: 12 Branch ------ REL_14_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/8a94af8a2d0f91ba9dbfb41a0c205e60afa509b2 Modified Files -------------- contrib/pageinspect/expected/page.out | 9 +++++++++ contrib/pageinspect/heapfuncs.c | 6 +++++- contrib/pageinspect/sql/page.sql | 5 +++++ contrib/pgstattuple/expected/pgstattuple.out | 24 ++++++++++++++++++++++++ contrib/pgstattuple/pgstattuple.c | 6 +++++- contrib/pgstattuple/sql/pgstattuple.sql | 12 ++++++++++++ 6 files changed, 60 insertions(+), 2 deletions(-) ^ permalink raw reply [nested|flat] 7+ messages in thread
* pgsql: Reintroduce support for sequences in pgstattuple and pageinspect @ 2024-09-12 21:33 Nathan Bossart <nathan@postgresql.org> 0 siblings, 0 replies; 7+ messages in thread From: Nathan Bossart @ 2024-09-12 21:33 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Reintroduce support for sequences in pgstattuple and pageinspect. Commit 4b82664156 restricted a number of functions provided by contrib modules to only relations that use the "heap" table access method. Sequences always use this table access method, but they do not advertise as such in the pg_class system catalog, so the aforementioned commit also (presumably unintentionally) removed support for sequences from some of these functions. This commit reintroduces said support for sequences to these functions and adds a couple of relevant tests. Co-authored-by: Ayush Vatsa Reviewed-by: Robert Haas, Michael Paquier, Matthias van de Meent Discussion: https://postgr.es/m/CACX%2BKaP3i%2Bi9tdPLjF5JCHVv93xobEdcd_eB%2B638VDvZ3i%3DcQA%40mail.gmail.com Backpatch-through: 12 Branch ------ REL_13_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/ca902529cc0fea8a0ef660b519640da09a2680ef Modified Files -------------- contrib/pageinspect/expected/page.out | 9 +++++++++ contrib/pageinspect/heapfuncs.c | 6 +++++- contrib/pageinspect/sql/page.sql | 5 +++++ contrib/pgstattuple/expected/pgstattuple.out | 24 ++++++++++++++++++++++++ contrib/pgstattuple/pgstattuple.c | 6 +++++- contrib/pgstattuple/sql/pgstattuple.sql | 12 ++++++++++++ 6 files changed, 60 insertions(+), 2 deletions(-) ^ permalink raw reply [nested|flat] 7+ messages in thread
* pgsql: Reintroduce support for sequences in pgstattuple and pageinspect @ 2024-09-12 21:33 Nathan Bossart <nathan@postgresql.org> 0 siblings, 0 replies; 7+ messages in thread From: Nathan Bossart @ 2024-09-12 21:33 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Reintroduce support for sequences in pgstattuple and pageinspect. Commit 4b82664156 restricted a number of functions provided by contrib modules to only relations that use the "heap" table access method. Sequences always use this table access method, but they do not advertise as such in the pg_class system catalog, so the aforementioned commit also (presumably unintentionally) removed support for sequences from some of these functions. This commit reintroduces said support for sequences to these functions and adds a couple of relevant tests. Co-authored-by: Ayush Vatsa Reviewed-by: Robert Haas, Michael Paquier, Matthias van de Meent Discussion: https://postgr.es/m/CACX%2BKaP3i%2Bi9tdPLjF5JCHVv93xobEdcd_eB%2B638VDvZ3i%3DcQA%40mail.gmail.com Backpatch-through: 12 Branch ------ REL_12_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/dd5670fa549ec5b06f331b55353f54df8b786449 Modified Files -------------- contrib/pageinspect/expected/page.out | 9 +++++++++ contrib/pageinspect/heapfuncs.c | 6 +++++- contrib/pageinspect/sql/page.sql | 5 +++++ contrib/pgstattuple/expected/pgstattuple.out | 24 ++++++++++++++++++++++++ contrib/pgstattuple/pgstattuple.c | 6 +++++- contrib/pgstattuple/sql/pgstattuple.sql | 12 ++++++++++++ 6 files changed, 60 insertions(+), 2 deletions(-) ^ permalink raw reply [nested|flat] 7+ messages in thread
end of thread, other threads:[~2024-09-12 21:33 UTC | newest] Thread overview: 7+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2024-09-12 21:33 pgsql: Reintroduce support for sequences in pgstattuple and pageinspect Nathan Bossart <nathan@postgresql.org> 2024-09-12 21:33 pgsql: Reintroduce support for sequences in pgstattuple and pageinspect Nathan Bossart <nathan@postgresql.org> 2024-09-12 21:33 pgsql: Reintroduce support for sequences in pgstattuple and pageinspect Nathan Bossart <nathan@postgresql.org> 2024-09-12 21:33 pgsql: Reintroduce support for sequences in pgstattuple and pageinspect Nathan Bossart <nathan@postgresql.org> 2024-09-12 21:33 pgsql: Reintroduce support for sequences in pgstattuple and pageinspect Nathan Bossart <nathan@postgresql.org> 2024-09-12 21:33 pgsql: Reintroduce support for sequences in pgstattuple and pageinspect Nathan Bossart <nathan@postgresql.org> 2024-09-12 21:33 pgsql: Reintroduce support for sequences in pgstattuple and pageinspect Nathan Bossart <nathan@postgresql.org>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox