From: Nathan Bossart <nathan@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Reintroduce support for sequences in pgstattuple and pageinspect
Date: Thu, 12 Sep 2024 21:33:27 +0000
Message-ID: <E1sorRP-000o5v-BQ@gemulon.postgresql.org> (raw)
Reintroduce support for sequences in pgstattuple and pageinspect.
Commit 4b82664156 restricted a number of functions provided by
contrib modules to only relations that use the "heap" table access
method. Sequences always use this table access method, but they do
not advertise as such in the pg_class system catalog, so the
aforementioned commit also (presumably unintentionally) removed
support for sequences from some of these functions. This commit
reintroduces said support for sequences to these functions and adds
a couple of relevant tests.
Co-authored-by: Ayush Vatsa
Reviewed-by: Robert Haas, Michael Paquier, Matthias van de Meent
Discussion: https://postgr.es/m/CACX%2BKaP3i%2Bi9tdPLjF5JCHVv93xobEdcd_eB%2B638VDvZ3i%3DcQA%40mail.gmail.com
Backpatch-through: 12
Branch
------
REL_13_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/ca902529cc0fea8a0ef660b519640da09a2680ef
Modified Files
--------------
contrib/pageinspect/expected/page.out | 9 +++++++++
contrib/pageinspect/heapfuncs.c | 6 +++++-
contrib/pageinspect/sql/page.sql | 5 +++++
contrib/pgstattuple/expected/pgstattuple.out | 24 ++++++++++++++++++++++++
contrib/pgstattuple/pgstattuple.c | 6 +++++-
contrib/pgstattuple/sql/pgstattuple.sql | 12 ++++++++++++
6 files changed, 60 insertions(+), 2 deletions(-)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: nathan@postgresql.org, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Reintroduce support for sequences in pgstattuple and pageinspect
In-Reply-To: <E1sorRP-000o5v-BQ@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox