From: Peter Geoghegan <pg@bowt.ie>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Update obsolete nbtree array preprocessing comments.
Date: Tue, 24 Sep 2024 16:59:21 +0000
Message-ID: <E1st8si-000iZG-PU@gemulon.postgresql.org> (raw)
Update obsolete nbtree array preprocessing comments.
The array->scan_key references fixed up at the end of preprocessing
start out as offsets into the arrayKeyData[] array (the array returned
by _bt_preprocess_array_keys at the start of preprocessing that involves
array scan keys). Offsets into the arrayKeyData[] array are no longer
guaranteed to be valid offsets into our original scan->keyData[] input
scan key array, but comments describing the array->scan_key references
still talked about scan->keyData[]. Update those comments.
Oversight in commit b5249741.
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/3da436ec09ae2f1a0167d4b74b30449f0292f581
Modified Files
--------------
src/backend/access/nbtree/nbtutils.c | 9 ++++-----
1 file changed, 4 insertions(+), 5 deletions(-)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: pg@bowt.ie, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Update obsolete nbtree array preprocessing comments.
In-Reply-To: <E1st8si-000iZG-PU@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox