pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Noah Misch <noah@leadboat.com>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Warn if LOCKTAG_TUPLE is held at commit, under debug_assertions.
Date: Tue, 24 Sep 2024 22:27:58 +0000
Message-ID: <E1stE0k-000khu-BV@gemulon.postgresql.org> (raw)

Warn if LOCKTAG_TUPLE is held at commit, under debug_assertions.

The current use always releases this locktag.  A planned use will
continue that intent.  It will involve more areas of code, making unlock
omissions easier.  Warn under debug_assertions, like we do for various
resource leaks.  Back-patch to v12 (all supported versions), the plan
for the commit of the new use.

Reviewed by Heikki Linnakangas.

Discussion: https://postgr.es/m/20240512232923.aa.nmisch@google.com

Branch
------
REL_17_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/f33bf1c7d501af56b257256349990ad9000dcffa

Modified Files
--------------
src/backend/storage/lmgr/lock.c | 10 ++++++++++
1 file changed, 10 insertions(+)



view thread (7+ messages)  latest in thread

Message-ID: <E1stE0k-000khu-BV@gemulon.postgresql.org>
Permalink:  ../E1stE0k-000khu-BV@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1stE0k-000khu-BV@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: noah@leadboat.com, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Warn if LOCKTAG_TUPLE is held at commit, under debug_assertions.
  In-Reply-To: <E1stE0k-000khu-BV@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox