pg.ddx.io pgsql-committers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
pgsql: Warn if LOCKTAG_TUPLE is held at commit, under debug_assertions. 7+ messages / 1 participants [nested] [flat]
* pgsql: Warn if LOCKTAG_TUPLE is held at commit, under debug_assertions. @ 2024-09-24 22:27 Noah Misch <noah@leadboat.com> 0 siblings, 0 replies; 7+ messages in thread From: Noah Misch @ 2024-09-24 22:27 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Warn if LOCKTAG_TUPLE is held at commit, under debug_assertions. The current use always releases this locktag. A planned use will continue that intent. It will involve more areas of code, making unlock omissions easier. Warn under debug_assertions, like we do for various resource leaks. Back-patch to v12 (all supported versions), the plan for the commit of the new use. Reviewed by Heikki Linnakangas. Discussion: https://postgr.es/m/20240512232923.aa.nmisch@google.com Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/dbf3f974ee04d24547690268b1fc2b7eb12b4ebc Modified Files -------------- src/backend/storage/lmgr/lock.c | 10 ++++++++++ 1 file changed, 10 insertions(+) ^ permalink raw reply [nested|flat] 7+ messages in thread
* pgsql: Warn if LOCKTAG_TUPLE is held at commit, under debug_assertions. @ 2024-09-24 22:27 Noah Misch <noah@leadboat.com> 0 siblings, 0 replies; 7+ messages in thread From: Noah Misch @ 2024-09-24 22:27 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Warn if LOCKTAG_TUPLE is held at commit, under debug_assertions. The current use always releases this locktag. A planned use will continue that intent. It will involve more areas of code, making unlock omissions easier. Warn under debug_assertions, like we do for various resource leaks. Back-patch to v12 (all supported versions), the plan for the commit of the new use. Reviewed by Heikki Linnakangas. Discussion: https://postgr.es/m/20240512232923.aa.nmisch@google.com Branch ------ REL_17_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/f33bf1c7d501af56b257256349990ad9000dcffa Modified Files -------------- src/backend/storage/lmgr/lock.c | 10 ++++++++++ 1 file changed, 10 insertions(+) ^ permalink raw reply [nested|flat] 7+ messages in thread
* pgsql: Warn if LOCKTAG_TUPLE is held at commit, under debug_assertions. @ 2024-09-24 22:27 Noah Misch <noah@leadboat.com> 0 siblings, 0 replies; 7+ messages in thread From: Noah Misch @ 2024-09-24 22:27 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Warn if LOCKTAG_TUPLE is held at commit, under debug_assertions. The current use always releases this locktag. A planned use will continue that intent. It will involve more areas of code, making unlock omissions easier. Warn under debug_assertions, like we do for various resource leaks. Back-patch to v12 (all supported versions), the plan for the commit of the new use. Reviewed by Heikki Linnakangas. Discussion: https://postgr.es/m/20240512232923.aa.nmisch@google.com Branch ------ REL_16_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/acc63ef4fbe686b0a21000d391d42bbf6b8296eb Modified Files -------------- src/backend/storage/lmgr/lock.c | 10 ++++++++++ 1 file changed, 10 insertions(+) ^ permalink raw reply [nested|flat] 7+ messages in thread
* pgsql: Warn if LOCKTAG_TUPLE is held at commit, under debug_assertions. @ 2024-09-24 22:27 Noah Misch <noah@leadboat.com> 0 siblings, 0 replies; 7+ messages in thread From: Noah Misch @ 2024-09-24 22:27 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Warn if LOCKTAG_TUPLE is held at commit, under debug_assertions. The current use always releases this locktag. A planned use will continue that intent. It will involve more areas of code, making unlock omissions easier. Warn under debug_assertions, like we do for various resource leaks. Back-patch to v12 (all supported versions), the plan for the commit of the new use. Reviewed by Heikki Linnakangas. Discussion: https://postgr.es/m/20240512232923.aa.nmisch@google.com Branch ------ REL_15_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/41e0ba33d5ab2b2301aa5d932836927bf69a76a8 Modified Files -------------- src/backend/storage/lmgr/lock.c | 10 ++++++++++ 1 file changed, 10 insertions(+) ^ permalink raw reply [nested|flat] 7+ messages in thread
* pgsql: Warn if LOCKTAG_TUPLE is held at commit, under debug_assertions. @ 2024-09-24 22:27 Noah Misch <noah@leadboat.com> 0 siblings, 0 replies; 7+ messages in thread From: Noah Misch @ 2024-09-24 22:27 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Warn if LOCKTAG_TUPLE is held at commit, under debug_assertions. The current use always releases this locktag. A planned use will continue that intent. It will involve more areas of code, making unlock omissions easier. Warn under debug_assertions, like we do for various resource leaks. Back-patch to v12 (all supported versions), the plan for the commit of the new use. Reviewed by Heikki Linnakangas. Discussion: https://postgr.es/m/20240512232923.aa.nmisch@google.com Branch ------ REL_14_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/c9de1b8ac8df344ea08316f2f7edd86b912d6b1c Modified Files -------------- src/backend/storage/lmgr/lock.c | 10 ++++++++++ 1 file changed, 10 insertions(+) ^ permalink raw reply [nested|flat] 7+ messages in thread
* pgsql: Warn if LOCKTAG_TUPLE is held at commit, under debug_assertions. @ 2024-09-24 22:27 Noah Misch <noah@leadboat.com> 0 siblings, 0 replies; 7+ messages in thread From: Noah Misch @ 2024-09-24 22:27 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Warn if LOCKTAG_TUPLE is held at commit, under debug_assertions. The current use always releases this locktag. A planned use will continue that intent. It will involve more areas of code, making unlock omissions easier. Warn under debug_assertions, like we do for various resource leaks. Back-patch to v12 (all supported versions), the plan for the commit of the new use. Reviewed by Heikki Linnakangas. Discussion: https://postgr.es/m/20240512232923.aa.nmisch@google.com Branch ------ REL_13_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/5ef9b4a2f79670a1cf9649e568fba7920a72e9a4 Modified Files -------------- src/backend/storage/lmgr/lock.c | 10 ++++++++++ 1 file changed, 10 insertions(+) ^ permalink raw reply [nested|flat] 7+ messages in thread
* pgsql: Warn if LOCKTAG_TUPLE is held at commit, under debug_assertions. @ 2024-09-24 22:27 Noah Misch <noah@leadboat.com> 0 siblings, 0 replies; 7+ messages in thread From: Noah Misch @ 2024-09-24 22:27 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Warn if LOCKTAG_TUPLE is held at commit, under debug_assertions. The current use always releases this locktag. A planned use will continue that intent. It will involve more areas of code, making unlock omissions easier. Warn under debug_assertions, like we do for various resource leaks. Back-patch to v12 (all supported versions), the plan for the commit of the new use. Reviewed by Heikki Linnakangas. Discussion: https://postgr.es/m/20240512232923.aa.nmisch@google.com Branch ------ REL_12_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/b779d37a3db2555a1d6c571c09eeabfe1c5caeb5 Modified Files -------------- src/backend/storage/lmgr/lock.c | 10 ++++++++++ src/include/storage/lock.h | 1 + 2 files changed, 11 insertions(+) ^ permalink raw reply [nested|flat] 7+ messages in thread
end of thread, other threads:[~2024-09-24 22:27 UTC | newest] Thread overview: 7+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2024-09-24 22:27 pgsql: Warn if LOCKTAG_TUPLE is held at commit, under debug_assertions. Noah Misch <noah@leadboat.com> 2024-09-24 22:27 pgsql: Warn if LOCKTAG_TUPLE is held at commit, under debug_assertions. Noah Misch <noah@leadboat.com> 2024-09-24 22:27 pgsql: Warn if LOCKTAG_TUPLE is held at commit, under debug_assertions. Noah Misch <noah@leadboat.com> 2024-09-24 22:27 pgsql: Warn if LOCKTAG_TUPLE is held at commit, under debug_assertions. Noah Misch <noah@leadboat.com> 2024-09-24 22:27 pgsql: Warn if LOCKTAG_TUPLE is held at commit, under debug_assertions. Noah Misch <noah@leadboat.com> 2024-09-24 22:27 pgsql: Warn if LOCKTAG_TUPLE is held at commit, under debug_assertions. Noah Misch <noah@leadboat.com> 2024-09-24 22:27 pgsql: Warn if LOCKTAG_TUPLE is held at commit, under debug_assertions. Noah Misch <noah@leadboat.com>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox