pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Andrew Dunstan <andrew@dunslane.net>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Bump MIN_WINNT for MINGW to clear a build error
Date: Mon, 30 Sep 2024 15:45:33 +0000
Message-ID: <E1svIaa-001b08-Pm@gemulon.postgresql.org> (raw)

Bump MIN_WINNT for MINGW to clear a build error

Because we have been setting this too low, there has been a
long-standing warning about a missing declaration for inet_pton().
Modern gcc now considers this an error, so we have been getting failures
on the buildfarm animal fairywren.

Fix suggested by Thomas Munro.

This isn't needed in later branches, as they already set MIN_WINNT
higher, nor on earlier branches because they don't use inet_pton().

Discussion: https://postgr.es/m/574fae43-c993-4a25-b0e5-04c3e9c36d6d@dunslane.net

Branch
------
REL_15_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/d700e8d75bc3844d866bf15c8cadbd72d759422d

Modified Files
--------------
src/include/port/win32.h | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)



Message-ID: <E1svIaa-001b08-Pm@gemulon.postgresql.org>
Permalink:  ../E1svIaa-001b08-Pm@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1svIaa-001b08-Pm@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: andrew@dunslane.net, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Bump MIN_WINNT for MINGW to clear a build error
  In-Reply-To: <E1svIaa-001b08-Pm@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox