From: Tom Lane <tgl@sss.pgh.pa.us>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Reject a copy EOF marker that has data ahead of it on the same l
Date: Tue, 01 Oct 2024 20:54:02 +0000
Message-ID: <E1svjsf-001la3-Tj@gemulon.postgresql.org> (raw)
Reject a copy EOF marker that has data ahead of it on the same line.
We have always documented that a copy EOF marker (\.) must appear
by itself on a line, and that is how psql interprets the rule.
However, the backend's actual COPY FROM logic only insists that
there not be data between the \. and the following newline.
Any data ahead of the \. is parsed as a final line of input.
It's hard to interpret this as anything but an ancient mistake
that we've faithfully carried forward. Continuing to allow it
is not cost-free, since it could mask client-side bugs that
unnecessarily backslash-escape periods (and thereby risk
accidentally creating an EOF marker). So, let's remove that
provision and throw error if the EOF marker isn't alone on its
line, matching what the documentation has said right along.
Adjust the relevant error messages to be clearer, too.
Discussion: https://postgr.es/m/ed659f37-a9dd-42a7-82b9-0da562cc4006@manitou-mail.org
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/da8a4c1666476648659dc5fb6fc01ba5cd5d16a1
Modified Files
--------------
src/backend/commands/copyfromparse.c | 22 ++++++++++++----------
src/test/regress/expected/copy.out | 13 +++++++++++++
src/test/regress/sql/copy.sql | 16 ++++++++++++++++
3 files changed, 41 insertions(+), 10 deletions(-)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: tgl@sss.pgh.pa.us, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Reject a copy EOF marker that has data ahead of it on the same l
In-Reply-To: <E1svjsf-001la3-Tj@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox