From: Robert Haas <rhaas@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: File size in a backup manifest should use uint64, not size_t.
Date: Wed, 02 Oct 2024 14:09:24 +0000
Message-ID: <E1sw02e-001rfO-2f@gemulon.postgresql.org> (raw)
File size in a backup manifest should use uint64, not size_t.
size_t is the size of an object in memory, not the size of a file on disk.
Thanks to Tom Lane for noting the error.
Discussion: http://postgr.es/m/1865585.1727803933@sss.pgh.pa.us
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/d94cf5ca7fad9cd81af5eac491bfbaf0facb9f6f
Modified Files
--------------
src/bin/pg_combinebackup/load_manifest.c | 4 ++--
src/bin/pg_combinebackup/load_manifest.h | 2 +-
src/bin/pg_combinebackup/write_manifest.c | 5 +++--
src/bin/pg_combinebackup/write_manifest.h | 2 +-
src/bin/pg_verifybackup/astreamer_verify.c | 13 ++++++++-----
src/bin/pg_verifybackup/pg_verifybackup.c | 16 +++++++++-------
src/bin/pg_verifybackup/pg_verifybackup.h | 2 +-
src/common/parse_manifest.c | 4 ++--
src/include/common/parse_manifest.h | 2 +-
9 files changed, 28 insertions(+), 22 deletions(-)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: rhaas@postgresql.org, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: File size in a backup manifest should use uint64, not size_t.
In-Reply-To: <E1sw02e-001rfO-2f@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox