From: Dean Rasheed <dean.a.rasheed@gmail.com>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Fix incorrect non-strict join recheck in MERGE WHEN NOT MATCHED
Date: Thu, 03 Oct 2024 11:54:13 +0000
Message-ID: <E1swKPM-001zOF-KB@gemulon.postgresql.org> (raw)
Fix incorrect non-strict join recheck in MERGE WHEN NOT MATCHED BY SOURCE.
If a MERGE command contains WHEN NOT MATCHED BY SOURCE actions, the
merge join condition is used by the executor to distinguish MATCHED
from NOT MATCHED BY SOURCE cases. However, this qual is executed using
the output from the join subplan node, which nulls the output from the
source relation in the not matched case, and so the result may be
incorrect if the join condition is "non-strict" -- for example,
something like "src.col IS NOT DISTINCT FROM tgt.col".
Fix this by enhancing the join recheck condition with an additional
"src IS NOT NULL" check, so that it does the right thing when
evaluated using the output from the join subplan.
Noted by Tom Lane while investigating bug #18634 from Alexander
Lakhin.
Back-patch to v17, where WHEN NOT MATCHED BY SOURCE support was added
to MERGE.
Discussion: https://postgr.es/m/18634-db5299c937877f2b%40postgresql.org
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/dddb5640c6d32f3d48994dac0f4e80d0f4567262
Modified Files
--------------
src/backend/optimizer/prep/prepjointree.c | 66 ++++++++++++++++++++++++++++---
src/test/regress/expected/merge.out | 22 +++++++++++
src/test/regress/sql/merge.sql | 18 +++++++++
3 files changed, 101 insertions(+), 5 deletions(-)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: dean.a.rasheed@gmail.com, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Fix incorrect non-strict join recheck in MERGE WHEN NOT MATCHED
In-Reply-To: <E1swKPM-001zOF-KB@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox