From: Michael Paquier <michael@paquier.xyz>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Remove assertion checking query ID in execMain.c
Date: Fri, 04 Oct 2024 03:52:26 +0000
Message-ID: <E1swZMg-00253p-5d@gemulon.postgresql.org> (raw)
Remove assertion checking query ID in execMain.c
This assertion has been added by 24f520594809, but Alexander Lakhin has
proved that the ExecutorRun() one can be broken by using a PL function
that manipulates compute_query_id and track_activities, while the ones
in ExecutorFinish() and ExecutorEnd() could be triggered when cleaning
up portals at the beginning of a new query execution.
Discussion: https://postgr.es/m/b37d8e6c-e83d-e157-8865-1b2460a6aef2@gmail.com
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/4dd308730029f5d90bd188f181c2dd9d7630ea69
Modified Files
--------------
src/backend/executor/execMain.c | 21 ---------------------
1 file changed, 21 deletions(-)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: michael@paquier.xyz, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Remove assertion checking query ID in execMain.c
In-Reply-To: <E1swZMg-00253p-5d@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox