From: Tom Lane <tgl@sss.pgh.pa.us>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: ecpg: avoid adding whitespace around '&' in connection URLs.
Date: Fri, 04 Oct 2024 16:01:58 +0000
Message-ID: <E1swkkg-00291W-D5@gemulon.postgresql.org> (raw)
ecpg: avoid adding whitespace around '&' in connection URLs.
The preprocessor really should not have done this to begin with.
The space after '&' was masked by ECPGconnect's skipping spaces
before option keywords, and the space before by dint of libpq
being (mostly) insensitive to trailing space in option values.
We fixed the one known problem with that in 920d51979. Hence
this patch is mostly cosmetic, and we'll just change it in HEAD.
Discussion: https://postgr.es/m/TY2PR01MB36286A7B97B9A15793335D18C1772@TY2PR01MB3628.jpnprd01.prod.outlook.com
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/f22e84df1dea96c8f4b0f7369ea60607fbb9ce10
Modified Files
--------------
src/interfaces/ecpg/ecpglib/connect.c | 5 ++++-
src/interfaces/ecpg/preproc/ecpg.trailer | 2 +-
src/interfaces/ecpg/test/expected/connect-test5.c | 2 +-
src/interfaces/ecpg/test/expected/connect-test5.stderr | 2 +-
4 files changed, 7 insertions(+), 4 deletions(-)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: tgl@sss.pgh.pa.us, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: ecpg: avoid adding whitespace around '&' in connection URLs.
In-Reply-To: <E1swkkg-00291W-D5@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox