pg.ddx.io pgsql-committers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
pgsql: Stabilize the test added by commit 022564f60c. 5+ messages / 1 participants [nested] [flat]
* pgsql: Stabilize the test added by commit 022564f60c. @ 2024-10-08 07:10 Amit Kapila <akapila@postgresql.org> 0 siblings, 0 replies; 5+ messages in thread From: Amit Kapila @ 2024-10-08 07:10 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Stabilize the test added by commit 022564f60c. The test was unstable in branches 14 and 15 as we were relying on the number of changes in the table having a toast column to start streaming. On branches >= 16, we have a GUC debug_logical_replication_streaming which can stream each change, so the test was stable in those branches. Change the test to use PREPARE TRANSACTION as that should make the result consistent and test the code changed in 022564f60c. Reported-by: Daniel Gustafsson as per buildfarm Author: Hou Zhijie, Amit Kapila Backpatch-through: 14 Discussion: https://postgr.es/m/8C2F86AA-981E-4803-B14D-E264C0255330@yesql.se Branch ------ REL_16_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/0c40d901907ab16dcfc3895a16d718231e2f8729 Modified Files -------------- contrib/test_decoding/expected/stream.out | 22 ---------------------- contrib/test_decoding/expected/twophase.out | 23 +++++++++++++++++++++++ contrib/test_decoding/sql/stream.sql | 22 ---------------------- contrib/test_decoding/sql/twophase.sql | 22 ++++++++++++++++++++++ 4 files changed, 45 insertions(+), 44 deletions(-) ^ permalink raw reply [nested|flat] 5+ messages in thread
* pgsql: Stabilize the test added by commit 022564f60c. @ 2024-10-08 07:10 Amit Kapila <akapila@postgresql.org> 0 siblings, 0 replies; 5+ messages in thread From: Amit Kapila @ 2024-10-08 07:10 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Stabilize the test added by commit 022564f60c. The test was unstable in branches 14 and 15 as we were relying on the number of changes in the table having a toast column to start streaming. On branches >= 16, we have a GUC debug_logical_replication_streaming which can stream each change, so the test was stable in those branches. Change the test to use PREPARE TRANSACTION as that should make the result consistent and test the code changed in 022564f60c. Reported-by: Daniel Gustafsson as per buildfarm Author: Hou Zhijie, Amit Kapila Backpatch-through: 14 Discussion: https://postgr.es/m/8C2F86AA-981E-4803-B14D-E264C0255330@yesql.se Branch ------ REL_17_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/c4b8a916f8a53379621825028532b038e004f891 Modified Files -------------- contrib/test_decoding/expected/stream.out | 22 ---------------------- contrib/test_decoding/expected/twophase.out | 23 +++++++++++++++++++++++ contrib/test_decoding/sql/stream.sql | 22 ---------------------- contrib/test_decoding/sql/twophase.sql | 22 ++++++++++++++++++++++ 4 files changed, 45 insertions(+), 44 deletions(-) ^ permalink raw reply [nested|flat] 5+ messages in thread
* pgsql: Stabilize the test added by commit 022564f60c. @ 2024-10-08 07:10 Amit Kapila <akapila@postgresql.org> 0 siblings, 0 replies; 5+ messages in thread From: Amit Kapila @ 2024-10-08 07:10 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Stabilize the test added by commit 022564f60c. The test was unstable in branches 14 and 15 as we were relying on the number of changes in the table having a toast column to start streaming. On branches >= 16, we have a GUC debug_logical_replication_streaming which can stream each change, so the test was stable in those branches. Change the test to use PREPARE TRANSACTION as that should make the result consistent and test the code changed in 022564f60c. Reported-by: Daniel Gustafsson as per buildfarm Author: Hou Zhijie, Amit Kapila Backpatch-through: 14 Discussion: https://postgr.es/m/8C2F86AA-981E-4803-B14D-E264C0255330@yesql.se Branch ------ REL_15_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/5ce0dcc99ad20bcb0de768d72d7126b6c033f5d9 Modified Files -------------- contrib/test_decoding/expected/stream.out | 20 -------------------- contrib/test_decoding/expected/twophase.out | 23 +++++++++++++++++++++++ contrib/test_decoding/sql/stream.sql | 18 ------------------ contrib/test_decoding/sql/twophase.sql | 22 ++++++++++++++++++++++ 4 files changed, 45 insertions(+), 38 deletions(-) ^ permalink raw reply [nested|flat] 5+ messages in thread
* pgsql: Stabilize the test added by commit 022564f60c. @ 2024-10-08 07:10 Amit Kapila <akapila@postgresql.org> 0 siblings, 0 replies; 5+ messages in thread From: Amit Kapila @ 2024-10-08 07:10 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Stabilize the test added by commit 022564f60c. The test was unstable in branches 14 and 15 as we were relying on the number of changes in the table having a toast column to start streaming. On branches >= 16, we have a GUC debug_logical_replication_streaming which can stream each change, so the test was stable in those branches. Change the test to use PREPARE TRANSACTION as that should make the result consistent and test the code changed in 022564f60c. Reported-by: Daniel Gustafsson as per buildfarm Author: Hou Zhijie, Amit Kapila Backpatch-through: 14 Discussion: https://postgr.es/m/8C2F86AA-981E-4803-B14D-E264C0255330@yesql.se Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/d759c1a0b864366d3592203c782027825ec4c8c8 Modified Files -------------- contrib/test_decoding/expected/stream.out | 22 ---------------------- contrib/test_decoding/expected/twophase.out | 23 +++++++++++++++++++++++ contrib/test_decoding/sql/stream.sql | 22 ---------------------- contrib/test_decoding/sql/twophase.sql | 22 ++++++++++++++++++++++ 4 files changed, 45 insertions(+), 44 deletions(-) ^ permalink raw reply [nested|flat] 5+ messages in thread
* pgsql: Stabilize the test added by commit 022564f60c. @ 2024-10-08 07:10 Amit Kapila <akapila@postgresql.org> 0 siblings, 0 replies; 5+ messages in thread From: Amit Kapila @ 2024-10-08 07:10 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Stabilize the test added by commit 022564f60c. The test was unstable in branches 14 and 15 as we were relying on the number of changes in the table having a toast column to start streaming. On branches >= 16, we have a GUC debug_logical_replication_streaming which can stream each change, so the test was stable in those branches. Change the test to use PREPARE TRANSACTION as that should make the result consistent and test the code changed in 022564f60c. Reported-by: Daniel Gustafsson as per buildfarm Author: Hou Zhijie, Amit Kapila Backpatch-through: 14 Discussion: https://postgr.es/m/8C2F86AA-981E-4803-B14D-E264C0255330@yesql.se Branch ------ REL_14_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/581092c9079f78194a4cff757de891fb2027de95 Modified Files -------------- contrib/test_decoding/expected/stream.out | 20 -------------------- contrib/test_decoding/expected/twophase.out | 23 +++++++++++++++++++++++ contrib/test_decoding/sql/stream.sql | 18 ------------------ contrib/test_decoding/sql/twophase.sql | 22 ++++++++++++++++++++++ 4 files changed, 45 insertions(+), 38 deletions(-) ^ permalink raw reply [nested|flat] 5+ messages in thread
end of thread, other threads:[~2024-10-08 07:10 UTC | newest] Thread overview: 5+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2024-10-08 07:10 pgsql: Stabilize the test added by commit 022564f60c. Amit Kapila <akapila@postgresql.org> 2024-10-08 07:10 pgsql: Stabilize the test added by commit 022564f60c. Amit Kapila <akapila@postgresql.org> 2024-10-08 07:10 pgsql: Stabilize the test added by commit 022564f60c. Amit Kapila <akapila@postgresql.org> 2024-10-08 07:10 pgsql: Stabilize the test added by commit 022564f60c. Amit Kapila <akapila@postgresql.org> 2024-10-08 07:10 pgsql: Stabilize the test added by commit 022564f60c. Amit Kapila <akapila@postgresql.org>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox