From: Amit Kapila <akapila@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Stabilize the test added by commit 022564f60c.
Date: Tue, 08 Oct 2024 07:10:57 +0000
Message-ID: <E1sy4Mz-002esJ-Uc@gemulon.postgresql.org> (raw)
Stabilize the test added by commit 022564f60c.
The test was unstable in branches 14 and 15 as we were relying on the
number of changes in the table having a toast column to start streaming.
On branches >= 16, we have a GUC debug_logical_replication_streaming which
can stream each change, so the test was stable in those branches.
Change the test to use PREPARE TRANSACTION as that should make the result
consistent and test the code changed in 022564f60c.
Reported-by: Daniel Gustafsson as per buildfarm
Author: Hou Zhijie, Amit Kapila
Backpatch-through: 14
Discussion: https://postgr.es/m/8C2F86AA-981E-4803-B14D-E264C0255330@yesql.se
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/d759c1a0b864366d3592203c782027825ec4c8c8
Modified Files
--------------
contrib/test_decoding/expected/stream.out | 22 ----------------------
contrib/test_decoding/expected/twophase.out | 23 +++++++++++++++++++++++
contrib/test_decoding/sql/stream.sql | 22 ----------------------
contrib/test_decoding/sql/twophase.sql | 22 ++++++++++++++++++++++
4 files changed, 45 insertions(+), 44 deletions(-)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: akapila@postgresql.org, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Stabilize the test added by commit 022564f60c.
In-Reply-To: <E1sy4Mz-002esJ-Uc@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox