From: Michael Paquier <michael@paquier.xyz>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Apply GUC name from central table in more places of guc.c
Date: Wed, 09 Oct 2024 09:53:44 +0000
Message-ID: <E1syTO5-0000sM-9K@gemulon.postgresql.org> (raw)
Apply GUC name from central table in more places of guc.c
The name extracted from the record of the GUC tables is applied to more
internal places of guc.c. This change has the advantage to simplify
parse_and_validate_value(), where the "name" was only used in elog
messages, while it was required to match with the name from the GUC
record.
pg_parameter_aclcheck() now passes the name of the GUC from its record
in two places rather than the caller's argument. The value given to
this function goes through convert_GUC_name_for_parameter_acl() that
does a simple ASCII downcasing.
Few GUCs mix character casing in core; one test is added for one of
these code paths with "IntervalStyle".
Author: Peter Smith, Michael Paquier
Discussion: https://postgr.es/m/ZwNh4vkc2NHJHnND@paquier.xyz
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/f3f06b13308e3c250bb8b0afee861744cda06cf6
Modified Files
--------------
src/backend/utils/misc/guc.c | 65 +++++++++++++++++++--------------------
src/test/regress/expected/guc.out | 4 +++
src/test/regress/sql/guc.sql | 3 ++
3 files changed, 39 insertions(+), 33 deletions(-)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: michael@paquier.xyz, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Apply GUC name from central table in more places of guc.c
In-Reply-To: <E1syTO5-0000sM-9K@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox