pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: ecpg: move some functions into a new file ecpg/preproc/util.c.
Date: Mon, 14 Oct 2024 17:55:19 +0000
Message-ID: <E1t0PHs-000p5R-4C@gemulon.postgresql.org> (raw)

ecpg: move some functions into a new file ecpg/preproc/util.c.

mm_alloc and mm_strdup were in type.c, which seems a completely
random choice.  No doubt the original author thought two small
functions didn't deserve their own file.  But I'm about to add
some more memory-management stuff beside them, so let's put them
in a less surprising place.  This seems like a better home for
mmerror, mmfatal, and the cat_str/make_str family, too.

Discussion: https://postgr.es/m/2011420.1713493114@sss.pgh.pa.us

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/f18231e817599246fc99a798c9bf57ab785db91f

Modified Files
--------------
src/interfaces/ecpg/preproc/Makefile         |   1 +
src/interfaces/ecpg/preproc/ecpg.header      | 129 ------------------
src/interfaces/ecpg/preproc/meson.build      |   1 +
src/interfaces/ecpg/preproc/preproc_extern.h |   4 +
src/interfaces/ecpg/preproc/type.c           |  24 ----
src/interfaces/ecpg/preproc/util.c           | 189 +++++++++++++++++++++++++++
6 files changed, 195 insertions(+), 153 deletions(-)



Message-ID: <E1t0PHs-000p5R-4C@gemulon.postgresql.org>
Permalink:  ../E1t0PHs-000p5R-4C@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1t0PHs-000p5R-4C@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: ecpg: move some functions into a new file ecpg/preproc/util.c.
  In-Reply-To: <E1t0PHs-000p5R-4C@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox