From: David Rowley <drowley@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Move clause_sides_match_join() into restrictinfo.h
Date: Tue, 15 Oct 2024 08:14:53 +0000
Message-ID: <E1t0chi-000u6b-AI@gemulon.postgresql.org> (raw)
Move clause_sides_match_join() into restrictinfo.h
Two near-identical copies of clause_sides_match_join() existed in
joinpath.c and analyzejoins.c. Deduplicate this by moving the function
into restrictinfo.h.
It isn't quite clear that keeping the inline property of this function
is worthwhile, but this commit is just an exercise in code
deduplication. More effort would be required to determine if the inline
property is worth keeping.
Author: James Hunter <james.hunter.pg@gmail.com>
Discussion: https://postgr.es/m/CAJVSvF7Nm_9kgMLOch4c-5fbh3MYg%3D9BdnDx3Dv7Fcb64zr64Q%40mail.gmail.com
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/2453196107de66cff0257feef2ff8585dcf9d924
Modified Files
--------------
src/backend/optimizer/path/joinpath.c | 44 +++++--------------------------
src/backend/optimizer/plan/analyzejoins.c | 31 ----------------------
src/include/optimizer/restrictinfo.h | 31 ++++++++++++++++++++++
3 files changed, 38 insertions(+), 68 deletions(-)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: drowley@postgresql.org, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Move clause_sides_match_join() into restrictinfo.h
In-Reply-To: <E1t0chi-000u6b-AI@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox